Skip to content

add finch #1504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

add finch #1504

wants to merge 6 commits into from

Conversation

SethTisue
Copy link
Member

motivation: finagle/finch#1417

@SethTisue
Copy link
Member Author

I did a run locally and I'm seeing similar compile errors as reported on the finch ticket:

[finch] [error] /Users/tisue/cb3/target-0.9.17/project-builds/finch-d51e08307f3d52080ece80921b9ca8e62d6eb526/core/src/test/scala/io/finch/BootstrapSpec.scala:43:16: overloaded method apply with alternatives:
[finch] [error]   (mapper: io.finch.internal.Mapper[cats.effect.IO,shapeless.HNil])io.finch.Endpoint[cats.effect.IO,mapper.Out] <and>
[finch] [error]   (input: io.finch.Input)io.finch.Endpoint.Result[cats.effect.IO,shapeless.HNil]
[finch] [error]  cannot be applied to (io.finch.Output[String])
[finch] [error]     val a = get("foo")(Ok("get foo"))
[finch] [error]                ^

I'll stand by as the finch folks dig into it.

@SethTisue
Copy link
Member Author

closing for now, for inactivity, but I'd be happy to return to it

@joroKr21
Copy link
Member

@SethTisue does it make sense to try again now that the fix was merged?

@SethTisue SethTisue reopened this Dec 15, 2021
@SethTisue SethTisue self-assigned this Dec 15, 2021
@SethTisue
Copy link
Member Author

local run on 2.13.8-bin-b59fa66

[info] Project finch-----------------------: SUCCESS (project rebuilt ok)

👍

I'll merge this PR after #1519 lands.

@SethTisue
Copy link
Member Author

actually I've just folded this into #1519

@SethTisue SethTisue closed this Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants