Add release notes/changelog/version diff for dependencies in private GitHub repos

[MPV]

These nice features don't work for dependencies whose git repos are private (thus need auth):

• Release Notes
• Changelog
• Version Diff

This is probably because the http client used for those doesn't seem to use the github token:

https://github.com/fthomas/scala-steward/blob/master/modules/core/src/main/scala/org/scalasteward/core/util/HttpExistenceClient.scala

[laughedelic]

The linked file doesn't exist anymore. Could any of the maintainers point to the potential places that would need changing to make it work with private repos?

[fthomas]

HttpExistenceClient has been renamed to UrlChecker. I think the Client used by UrlChecker needs do authenticated calls for anything that goes to VCSCfg#apiHost. I once tried this in this old branch (https://github.com/scala-steward-org/scala-steward/compare/topic/VCSClient) but then ran out of steam.

[fthomas]

There is now a PR at #2920 that fixes this if someone wants to give it a try.

[laughedelic]

Great news! Thanks!

Can I try this version with the scala-steward-action?

[fthomas]

Yes, just set the scala-steward-version option of the action to 0.20.0-61-1f0282a6-SNAPSHOT for example. Available snapshot versions are here: https://oss.sonatype.org/content/repositories/snapshots/org/scala-steward/scala-steward-core_2.13/

[lenguyenthanh]

This currently doesn't work for private github repositories. because normal url like https://github.com/org/private-repository` will not accept any token. So both basic auth and jwt token don't work.

I'm not sure this is a regression or it has never worked 🤔

Can anyone confirm?