Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authenticate UrlChecker calls to API host #2920

Merged
merged 4 commits into from
Jan 14, 2023
Merged

Conversation

fthomas
Copy link
Member

@fthomas fthomas commented Jan 14, 2023

This authenticates UrlChecker calls if the scheme and host of the request URL match ForgeCfg#apiHost.

Hopefully fixes #1468.

This authenticates `UrlChecker` calls if the scheme and host of the
request URL match `ForgeCfg#apiHost`.
@fthomas fthomas added the enhancement New feature or request label Jan 14, 2023
@fthomas fthomas added this to the 0.21.0 milestone Jan 14, 2023
@codecov
Copy link

codecov bot commented Jan 14, 2023

Codecov Report

Base: 89.84% // Head: 89.99% // Increases project coverage by +0.14% 🎉

Coverage data is based on head (132840c) compared to base (653080f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2920      +/-   ##
==========================================
+ Coverage   89.84%   89.99%   +0.14%     
==========================================
  Files         154      154              
  Lines        3033     3038       +5     
  Branches      213      203      -10     
==========================================
+ Hits         2725     2734       +9     
+ Misses        308      304       -4     
Impacted Files Coverage Δ
...la/org/scalasteward/core/application/Context.scala 74.02% <100.00%> (+5.60%) ⬆️
...a/org/scalasteward/core/forge/ForgeSelection.scala 100.00% <100.00%> (ø)
.../scala/org/scalasteward/core/util/UrlChecker.scala 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@mzuehlke mzuehlke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting that both braches are already covered with the existing tests

@fthomas
Copy link
Member Author

fthomas commented Jan 14, 2023

interesting that both braches are already covered with the existing tests

Right. I'll add a test that checks that auth headers are actually added to the request. :-)

@fthomas
Copy link
Member Author

fthomas commented Jan 14, 2023

Just tested this with a private Bitbucket Server and it works for me. The repo URL, release notes, and version diff are now included in the PR body.

Copy link
Contributor

@exoego exoego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@fthomas fthomas merged commit 86ad84a into main Jan 14, 2023
@fthomas fthomas deleted the topic/auth-url-checker-calls branch January 14, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add release notes/changelog/version diff for dependencies in private GitHub repos
3 participants