-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Authenticate UrlChecker calls to API host #2920
Conversation
This authenticates `UrlChecker` calls if the scheme and host of the request URL match `ForgeCfg#apiHost`.
Codecov ReportBase: 89.84% // Head: 89.99% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2920 +/- ##
==========================================
+ Coverage 89.84% 89.99% +0.14%
==========================================
Files 154 154
Lines 3033 3038 +5
Branches 213 203 -10
==========================================
+ Hits 2725 2734 +9
+ Misses 308 304 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting that both braches are already covered with the existing tests
Right. I'll add a test that checks that auth headers are actually added to the request. :-) |
Just tested this with a private Bitbucket Server and it works for me. The repo URL, release notes, and version diff are now included in the PR body. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
This authenticates
UrlChecker
calls if the scheme and host of the request URL matchForgeCfg#apiHost
.Hopefully fixes #1468.