Logo metadata templates #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rin-st
commented
Oct 7, 2024
…etadata-templates
This was referenced Oct 7, 2024
technophile-04
approved these changes
Oct 14, 2024
carletex
reviewed
Oct 16, 2024
Comment on lines
+102
to
+103
| <span className="font-bold leading-tight">${logoText}</span> | ||
| <span className="text-xs">${logoDescription}</span> |
There was a problem hiding this comment.
I know that this is already merged, but a nitpick:
I think logoTitle + (logoSubtitle | logoDescription | logoText) is more intuitive (logoText feels the same as logoDescription)
We can ignore if it's too nitpicky :D
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started here scaffold-eth/create-eth-extensions#29
Changes:
For now everything with string variables
to test