Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document latest template files. #140

Open
technophile-04 opened this issue Oct 15, 2024 · 1 comment
Open

Document latest template files. #140

technophile-04 opened this issue Oct 15, 2024 · 1 comment

Comments

@technophile-04
Copy link
Collaborator

Description:

We have documenting stuff at TEMPLATING-FILES.md with examples to corresponding .args.mjs lets add #131, #138 , #129 .

Also #138 we don't actually have any examples (might update eip-5792 example with it) but I think we are gonna hit similar situation in future where we add things to template.mjs and don't have corresponding example of .args.mjs (it might live in 3rd party extension).

What if we create a fake extension which uses all the .args.mjs and all the fields in init. and all the example args.mjs file point to it. So whenever we add .template.mjs file we also add corresponding .args.mjs in that fake extension. This will also help test the PR which adds the template.mjs file.

@carletex
Copy link
Member

What if we create a fake extension which uses all the .args.mjs and all the fields in init. and all the example args.mjs file point to it. So whenever we add .template.mjs file we also add corresponding .args.mjs in that fake extension. This will also help test the PR which adds the template.mjs file.

💯 Love this idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants