Skip to content

Fix DataPack early handle free #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2019
Merged

Fix DataPack early handle free #581

merged 1 commit into from
Jul 22, 2019

Conversation

geominorai
Copy link
Contributor

Fixes #580

Description

DataPack handle was freed early when it's needed in one case later on.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.

@geominorai
Copy link
Contributor Author

The source file also had mixed line endings, which is why there were extra lines changed here aside from the fix.

CrazyHackGUT
CrazyHackGUT approved these changes Jul 22, 2019
View reviewed changes
Copy link
Contributor

@CrazyHackGUT CrazyHackGUT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@rumblefrog rumblefrog merged commit 41c1ab8 into sbpp:v1.x Jul 22, 2019
@geominorai geominorai deleted the patch/580 branch July 23, 2019 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@CrazyHackGUT CrazyHackGUT CrazyHackGUT approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error logs
3 participants
@geominorai @CrazyHackGUT @rumblefrog