Merge pull request #581 from geominorai/patch/580

Fix DataPack early handle free

Co-Author: geominorai <geominorai@users.noreply.github.com>

Author: rumblefrog

game/addons/sourcemod/scripting/sbpp_main.sp

@@ -1183,14 +1183,14 @@ public void VerifyInsert(Database db, DBResultSet results, const char[] error, D
 	}
 
 	// Kick player
-	if (GetClientUserId(client) == UserId)
-	{
-		char length[32];
-		if(time == 0)
-			FormatEx(length, sizeof(length), "permament");
-		else
-			FormatEx(length, sizeof(length), "%d %s", time, time == 1 ? "minute" : "minutes");
-		KickClient(client, "%t\n\n%t", "Banned Check Site", WebsiteAddress, "Kick Reason", admin, Reason, length);
+	if (GetClientUserId(client) == UserId)
+	{
+		char length[32];
+		if(time == 0)
+			FormatEx(length, sizeof(length), "permament");
+		else
+			FormatEx(length, sizeof(length), "%d %s", time, time == 1 ? "minute" : "minutes");
+		KickClient(client, "%t\n\n%t", "Banned Check Site", WebsiteAddress, "Kick Reason", admin, Reason, length);
 	}
 }
 
@@ -1295,7 +1295,6 @@ public void SelectUnbanCallback(Database db, DBResultSet results, const char[] e
 	dataPack.ReadString(reason, sizeof(reason));
 	dataPack.ReadString(arg, sizeof(arg));
 	dataPack.ReadString(adminAuth, sizeof(adminAuth));
-	delete dataPack;
 
 	db.Escape(reason, unbanReason, sizeof(unbanReason));
 
@@ -1307,6 +1306,7 @@ public void SelectUnbanCallback(Database db, DBResultSet results, const char[] e
 		{
 			PrintToChat(admin, "%ssm_unban failed", Prefix);
 		}
+		delete dataPack;
 		return;
 	}
 
@@ -1319,6 +1319,7 @@ public void SelectUnbanCallback(Database db, DBResultSet results, const char[] e
 		} else {
 			PrintToServer("%sNo active bans found for that filter", Prefix);
 		}
+		delete dataPack;
 		return;
 	}
 
@@ -2562,14 +2563,14 @@ stock void UTIL_InsertTempBan(int time, const char[] name, const char[] auth, co
 
 	ServerCommand(buffer);
 
-	if (IsClientInGame(client))
+	if (IsClientInGame(client))
 	{
-		char length[32];
-		if(time == 0)
-			FormatEx(length, sizeof(length), "permament");
-		else
-			FormatEx(length, sizeof(length), "%d %s", time, time == 1 ? "minute" : "minutes");
-		KickClient(client, "%t\n\n%t", "Banned Check Site", WebsiteAddress, "Kick Reason", admin, reason, length);
+		char length[32];
+		if(time == 0)
+			FormatEx(length, sizeof(length), "permament");
+		else
+			FormatEx(length, sizeof(length), "%d %s", time, time == 1 ? "minute" : "minutes");
+		KickClient(client, "%t\n\n%t", "Banned Check Site", WebsiteAddress, "Kick Reason", admin, reason, length);
 	}
 
 	char banName[128], banReason[256], query[512];
@@ -2651,10 +2652,10 @@ stock void PrepareBan(int client, int target, int time, char[] reason, int size)
 			}
 		}
 		LogAction(client, target, "\"%L\" banned \"%L\" (minutes \"%d\") (reason \"%s\")", client, target, time, reason);
-		char length[32];
-		if(time == 0)
-			FormatEx(length, sizeof(length), "permament");
-		else
+		char length[32];
+		if(time == 0)
+			FormatEx(length, sizeof(length), "permament");
+		else
 			FormatEx(length, sizeof(length), "%d %s", time, time == 1 ? "minute" : "minutes");
 		if (time > 5 || time == 0)
 			time = 5;