Skip to content

Commit

Permalink
conformance-profile: Remove experimental build tag
Browse files Browse the repository at this point in the history
This is to make it easier for some implementation that imports the
conformance test framework and run tests in the same codebase.

Understand that cleaning up of similar/duplicated code is required to
have a clean conformance test framework, however, such work might delay
v1.0.0 GA release, hence, I only remove the build tag to remove the soft
blocker in this PR. Subsequent cleanup/optimization can be done later.

Relates: kubernetes-sigs#2242
Signed-off-by: Tam Mach <sayboras@yahoo.com>
  • Loading branch information
sayboras committed Aug 23, 2023
1 parent e9b02c5 commit 231624f
Show file tree
Hide file tree
Showing 10 changed files with 6 additions and 32 deletions.
5 changes: 1 addition & 4 deletions conformance/apis/v1alpha1/conformancereport.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
//go:build experimental
// +build experimental

/*
Copyright 2023 The Kubernetes Authors.
Expand Down Expand Up @@ -71,7 +68,7 @@ type Implementation struct {
// addresses.
// Rather than Github usernames or email addresses you can provide a URL to the relevant
// support pages for the project. Ideally this would be something like the issue creation page
// on a repository, but for projects without a publicly exposed repository a general support
// on a repository, but for projects without a publicly exposed repository a general support
// page URL can be provided.
Contact []string `json:"contact"`
}
7 changes: 3 additions & 4 deletions conformance/apis/v1alpha1/doc.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
//go:build experimental
// +build experimental

/*
Copyright 2023 The Kubernetes Authors.
Expand All @@ -23,14 +20,16 @@ limitations under the License.
// are written in Golang and execute the conformance test suite as a Golang
// library.
//
// $ go test ./conformance/... -args ${CONFORMANCE_ARGS}
//
// Note that currently all sub-packages are considered "experimental" in that
// they aren't intended for general use or to be distributed as part of a
// release so there is no way to use them by default when using the Golang
// library at this time. If you don't know for sure that you want to use these
// features, then you should not use them. If you would like to opt into these
// unreleased features use Go build tags to enable them, e.g.:
//
// $ GOFLAGS='-tags=experimental' go test ./conformance/... -args ${CONFORMANCE_ARGS}
// $ go test ./conformance/... -args ${CONFORMANCE_ARGS}
//
// Please note that everything here is considered experimental and subject to
// change. Expect breaking changes and/or complete removals if you start using
Expand Down
3 changes: 0 additions & 3 deletions conformance/apis/v1alpha1/profilereport.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
//go:build experimental
// +build experimental

/*
Copyright 2023 The Kubernetes Authors.
Expand Down
3 changes: 0 additions & 3 deletions conformance/apis/v1alpha1/result.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
//go:build experimental
// +build experimental

/*
Copyright 2023 The Kubernetes Authors.
Expand Down
3 changes: 0 additions & 3 deletions conformance/apis/v1alpha1/statistics.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
//go:build experimental
// +build experimental

/*
Copyright 2023 The Kubernetes Authors.
Expand Down
3 changes: 0 additions & 3 deletions conformance/experimental_conformance_test.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
//go:build experimental
// +build experimental

/*
Copyright 2023 The Kubernetes Authors.
Expand Down
3 changes: 0 additions & 3 deletions conformance/utils/flags/experimental_flags.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
//go:build experimental
// +build experimental

/*
Copyright 2023 The Kubernetes Authors.
Expand Down
3 changes: 0 additions & 3 deletions conformance/utils/suite/experimental_profiles.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
//go:build experimental
// +build experimental

/*
Copyright 2023 The Kubernetes Authors.
Expand Down
4 changes: 1 addition & 3 deletions conformance/utils/suite/experimental_reports.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
//go:build experimental
// +build experimental

/*
Copyright 2023 The Kubernetes Authors.
Expand All @@ -21,6 +18,7 @@ package suite

import (
"k8s.io/apimachinery/pkg/util/sets"

confv1a1 "sigs.k8s.io/gateway-api/conformance/apis/v1alpha1"
)

Expand Down
4 changes: 1 addition & 3 deletions conformance/utils/suite/experimental_suite.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
//go:build experimental
// +build experimental

/*
Copyright 2023 The Kubernetes Authors.
Expand Down Expand Up @@ -29,6 +26,7 @@ import (

v1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/util/sets"

"sigs.k8s.io/gateway-api/conformance"
confv1a1 "sigs.k8s.io/gateway-api/conformance/apis/v1alpha1"
"sigs.k8s.io/gateway-api/conformance/utils/config"
Expand Down

0 comments on commit 231624f

Please sign in to comment.