Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conformance Profiles: Remove experimental build tag #2242

Closed
Tracked by #1709
shaneutt opened this issue Jul 27, 2023 · 2 comments · Fixed by #2327
Closed
Tracked by #1709

Conformance Profiles: Remove experimental build tag #2242

shaneutt opened this issue Jul 27, 2023 · 2 comments · Fixed by #2327
Labels
area/conformance priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-blocker MUST be completed to complete the milestone triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone
v0.8.0

Comments

@shaneutt
Copy link
Member

Currently we require the experimental Golang build tag to be provided to use the CLI or Go library for the conformance profiles version of the conformance test suite.

We've received feedback that this is seemingly problematic for some community members, and they are in favor of dropping it.

As such, the purpose of this task is to drop that build tag and make the profiles enabled test suite available in a normal build.
@shaneutt shaneutt mentioned this issue Jul 27, 2023
Merged
@shaneutt shaneutt added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jul 27, 2023
@shaneutt shaneutt mentioned this issue Aug 14, 2023
Closed
@shaneutt
Copy link
Member Author

/triage accepted
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Aug 14, 2023
@shaneutt shaneutt removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Aug 14, 2023
sayboras added a commit to sayboras/gateway-api that referenced this issue Aug 20, 2023
@sayboras
conformance-profile: Remove experimental build tag
d90f0f4 
This is to make it easier for some implementation that imports the
conformance test framework and run tests in the same codebase.

Understand that cleaning up of similar/duplicated code is required to
have a clean conformance test framework, however, such work might delay
v1.0.0 GA release, hence, I only remove the build tag to remove the soft
blocker in this PR. Subsequent cleanup/optimization can be done later.

Relates: kubernetes-sigs#2242
Signed-off-by: Tam Mach <sayboras@yahoo.com>
@sayboras sayboras mentioned this issue Aug 20, 2023
Merged
sayboras added a commit to sayboras/gateway-api that referenced this issue Aug 23, 2023
@sayboras
conformance-profile: Remove experimental build tag
231624f 
This is to make it easier for some implementation that imports the
conformance test framework and run tests in the same codebase.

Understand that cleaning up of similar/duplicated code is required to
have a clean conformance test framework, however, such work might delay
v1.0.0 GA release, hence, I only remove the build tag to remove the soft
blocker in this PR. Subsequent cleanup/optimization can be done later.

Relates: kubernetes-sigs#2242
Signed-off-by: Tam Mach <sayboras@yahoo.com>
sayboras added a commit to sayboras/gateway-api that referenced this issue Aug 23, 2023
@sayboras
conformance-profile: Remove experimental build tag
d0c1ce1 
This is to make it easier for some implementation that imports the
conformance test framework and run tests in the same codebase.

Understand that cleaning up of similar/duplicated code is required to
have a clean conformance test framework, however, such work might delay
v1.0.0 GA release, hence, I only remove the build tag to remove the soft
blocker in this PR. Subsequent cleanup/optimization can be done later.

Relates: kubernetes-sigs#2242
Signed-off-by: Tam Mach <sayboras@yahoo.com>
sayboras added a commit to sayboras/gateway-api that referenced this issue Aug 23, 2023
@sayboras
conformance-profile: Remove experimental build tag
f9a8505 
This is to make it easier for some implementation that imports the
conformance test framework and run tests in the same codebase.

Understand that cleaning up of similar/duplicated code is required to
have a clean conformance test framework, however, such work might delay
v1.0.0 GA release, hence, I only remove the build tag to remove the soft
blocker in this PR. Subsequent cleanup/optimization can be done later.

Relates: kubernetes-sigs#2242
Signed-off-by: Tam Mach <sayboras@yahoo.com>
@michaelbeaumont
Copy link
Contributor

michaelbeaumont commented Aug 25, 2023 •
edited
Loading

I suggest getting this fixed for v0.8.0, I'm seeing build issues with v0.8.0-rc2 with the experimental tag after #2323, it looks like the experimental tagged files weren't updated with the changes. @shaneutt

@shaneutt shaneutt linked a pull request Aug 28, 2023 that will close this issue
conformance-profile: Remove experimental build tag #2327
Merged
@shaneutt shaneutt added this to the v0.8.0 milestone Aug 28, 2023
@shaneutt shaneutt added the release-blocker MUST be completed to complete the milestone label Aug 28, 2023
@programmer04 programmer04 mentioned this issue Sep 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/conformance priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-blocker MUST be completed to complete the milestone triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
No open projects
Gateway API: The Road to GA
Status: Done
Milestone
v0.8.0
Development

Successfully merging a pull request may close this issue.

conformance-profile: Remove experimental build tag sayboras/gateway-api
3 participants
@michaelbeaumont @shaneutt @k8s-ci-robot