Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/47 cookie support #74

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

robin-schoch
Copy link

Hi,

This PR partially addresses cookie handling. It includes:

  • Parsing cookies from incoming requests
  • Parsing cookies from server responses
  • Creating new cookies on the server side

However, the following cookie-related tasks are not implemented:

  • Implementing client-side cookie storage
  • Attaching matching cookies to outgoing client requests
  • Sanitizing cookie values

Known issues with the current implementation:

  • Timezone defaults to GMT without properly accounting for the delta
  • Some default values, like domain, are not correctly set when reading cookies on the client (currently defaults to None)
  • I’m fairly new to Mojo, so this code might not be effective mojo

@saviorand
Copy link
Owner

Hi, thanks, looks great! Will review in more detail over the weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants