Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: urlencode filename for separate mod targets #47

Merged
merged 2 commits into from
Mar 7, 2024
Merged

fix: urlencode filename for separate mod targets #47

merged 2 commits into from
Mar 7, 2024

Commits on Mar 6, 2024

  1. fix: urlencode filename for separate mod targets 

    When a mod's name contains characters that should be urlencoded,
any newly-uploaded versions cannot be download because of some
errors regarding the URL being invalid. Make sure the returned key
is urlencoded for consistency with the rest of the codebase.

Signed-off-by: Angel Pons <th3fanbus@gmail.com>
    @Th3Fanbus
    Th3Fanbus committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    1522bf3 View commit details
    Browse the repository at this point in the history

  2. fix: urlencode version in RenameFilename 

    As per Mircea's comment on [satisfactorymodding#44 (comment)](satisfactorymodding#44 (comment)):

    I've also now noticed that RenameVersion is also not correctly
    escaping the filename, it's only escaping the mod's name, and
    not the version, which is what causes mods that use build
    metadata in the version (+build.1234) to fail, so that one
    should need a similar fix of encoding the filename.

Signed-off-by: Angel Pons <th3fanbus@gmail.com>
    @Th3Fanbus
    Th3Fanbus committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    f323a9f View commit details
    Browse the repository at this point in the history