Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completely changes how SAS logs are rendered.
Currently, the SAS log and listing details are rendered as an HTML file which, through pygments, allows the log to be colored consistently with other SAS clients.
This caused problems in conversion to PDF, HTML, and other destinations and if you run from console instead of a notebook.
This PR renders the SAS log as text using ANSI escape sequences to color the log. The goal is that users will not notice any difference in routine usage and see a huge improvement in use cases beyond just entering code.
I've also taken advantage of metakernal functions to flag cells with ERROR messages as failing while producing the same output as before. This is a helpful visual cue to the user that there is an error and will aid in auto-grading from
nbgrader
through this PR jupyter/nbgrader/pull/1356Thanks to @dsblank for committing my PR Calysto/metakernel/pull/205 of adding a new method
Error_display
that will show the error in the log with context and the listing output.This PR also removes the dependency on pygments since everything can be done with IPython and text.
This update also addresses issues #13 and #42
Additional logging was also added to improve the ability to debug issues.