add Error_display method to _metakernel.py #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add `Error_display` method that will all an error to be thrown and also display non-text objects In the SAS Kernel, based on metakernel, there are two streams of informaiton -- the log and the list. In parsing the log you can determine if there is an error and lag the cell as such but in a log program there could be valid output (in the form of HTML) that is helpful to the user. This commit adds a new method to not change existing behavior.
|
This looks reasonable. Could you add an example in the example directory in lieu of a test? |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add
Error_displaymethod that will allow an error to be thrown and also display non-text objectsIn the SAS Kernel, based on metakernel, there are two streams of information -- the log and the list. In parsing the log you can determine if there is an error and lag the cell as such but in a log program there could be valid output (in the form of HTML) that is helpful to the user.
This commit adds a new method to not change existing behavior.