Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix escaped backslash crash #1870

Merged
merged 3 commits into from
Jan 25, 2023
Merged

Fix escaped backslash crash #1870

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0a7f73b
Fix escaped backslash crash
jathak Jan 17, 2023
f1dd9e0
Code review
jathak Jan 17, 2023
ad4ac59
Merge branch 'main' into backslash-crash-fix
jathak Jan 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
* Produce a better error message for a number with a leading `+` or `-`, a
decimal point, but no digits.

* Fix a crash when a selector ends in an escaped backslash.

## 1.57.1

* No user-visible changes.
Expand Down
2 changes: 1 addition & 1 deletion lib/src/utils.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ int? _lastNonWhitespace(String string, {bool excludeEscape = false}) {
if (!isWhitespace(codeUnit)) {
if (excludeEscape &&
i != 0 &&
i != string.length &&
i != string.length - 1 &&
codeUnit == $backslash) {
return i + 1;
} else {
Expand Down