Fix escaped backslash crash #1870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorskees
reviewed
Jan 17, 2023
lib/src/utils.dart
Outdated
| @@ -115,7 +115,8 @@ int? _lastNonWhitespace(String string, {bool excludeEscape = false}) { | |||
| if (excludeEscape && | |||
| i != 0 && | |||
| i != string.length && | |||
There was a problem hiding this comment.
Can i ever be string.length? I think this condition should actually be checking against string.length - 1. That said, the fix in this PR does appear to solve the crash as well
There was a problem hiding this comment.
Good point. That's actually a cleaner solution, so I'll change it to that. Thanks!
nex3
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1855.
See sass/sass-spec#1867.