Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore Add stream headers and header specific methods #510

Conversation

henomis
Copy link
Contributor

@henomis henomis commented Oct 10, 2023

Describe the change
This branch:

  • adds header specific methods
  • adds headers for streams
  • adds headers documentation in README

Describe your solution
httpHeader struct implements specific methods to easily get information. The same type has been embedded into streams.

Tests
Tests have been integrated testing new methods

issues:

Related PR:

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #510 (72ee180) into master (8e165dc) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #510      +/-   ##
==========================================
+ Coverage   97.52%   97.56%   +0.04%     
==========================================
  Files          18       18              
  Lines         850      864      +14     
==========================================
+ Hits          829      843      +14     
  Misses         15       15              
  Partials        6        6              
Files Coverage Δ
chat_stream.go 100.00% <100.00%> (ø)
client.go 100.00% <100.00%> (ø)
stream.go 100.00% <100.00%> (ø)

@henomis henomis marked this pull request as ready for review October 10, 2023 07:04
@henomis
Copy link
Contributor Author

henomis commented Oct 10, 2023

Closed beacusa it's a duplicated. Implemented here: #507

@henomis henomis closed this Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant