-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support get http header and x-ratelimit-* headers #507
Conversation
Codecov Report
@@ Coverage Diff @@
## master #507 +/- ##
==========================================
+ Coverage 97.52% 97.58% +0.05%
==========================================
Files 18 19 +1
Lines 850 871 +21
==========================================
+ Hits 829 850 +21
Misses 15 15
Partials 6 6
|
@liushuangls thanks for the PR! Got some conflicts after merging #506, let's settle them and roll a new release with this one merged. |
Done. |
@liushuangls @sashabaranov I just sumbitted my PR on the (more or less) same topic, I only saw this PR after submbitted mine. However: @liushuangls just some suggestions:
@sashabaranov let me know how we can handle this duplicate. My personal idea is to go ahead with Liu's PR (with the above suggestions) and use my PR to add headers on streams (with embedded |
@henomis Thanks for your suggestion, the relevant code has been modified |
@henomis The reason why the |
Ok @liushuangls I understand. And what about aliasing type ResetRequests string
func (r *ResetRequest) Time() time.Time {
// implement here the parser
}
func (r *ResetRequest) String() string{
// implement here stringer
} |
Very good suggestion, code has been modified. |
I've just closed my PR, since I think this is a good implementation now. |
…#1159) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/sashabaranov/go-openai](https://togithub.com/sashabaranov/go-openai) | require | minor | `v1.15.4` -> `v1.16.0` | --- ### Release Notes <details> <summary>sashabaranov/go-openai (github.com/sashabaranov/go-openai)</summary> ### [`v1.16.0`](https://togithub.com/sashabaranov/go-openai/releases/tag/v1.16.0) [Compare Source](https://togithub.com/sashabaranov/go-openai/compare/v1.15.4...v1.16.0) #### What's Changed - Add DotProduct Method and README Example for Embedding Similarity Search by [@​ealvar3z](https://togithub.com/ealvar3z) in [https://github.com/sashabaranov/go-openai/pull/492](https://togithub.com/sashabaranov/go-openai/pull/492) - fix: use any for n_epochs by [@​henomis](https://togithub.com/henomis) in [https://github.com/sashabaranov/go-openai/pull/499](https://togithub.com/sashabaranov/go-openai/pull/499) - Feat Add headers to openai responses by [@​henomis](https://togithub.com/henomis) in [https://github.com/sashabaranov/go-openai/pull/506](https://togithub.com/sashabaranov/go-openai/pull/506) - Support get http header and x-ratelimit-\* headers by [@​liushuangls](https://togithub.com/liushuangls) in [https://github.com/sashabaranov/go-openai/pull/507](https://togithub.com/sashabaranov/go-openai/pull/507) **Full Changelog**: sashabaranov/go-openai@v1.15.4...v1.16.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/go-skynet/LocalAI). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44LjEiLCJ1cGRhdGVkSW5WZXIiOiIzNy44LjEiLCJ0YXJnZXRCcmFuY2giOiJtYXN0ZXIifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Describe the change
Support get http header and x-ratelimit-* headers
Issue:
Compare that to #506 this PR support stream mode and x-ratelimit-* headers