-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add typechecking #51
Conversation
- Add typehint coverate to full library - Update tox config - Fix shim removal to only remove shims under the same conditions as we would activate the finders in question Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
The sheer number of bugs this caught is actually crazy. |
- add reload capability to finders and system path - make sure we remove all NoneTypes - leave shims on the path if we don't detect pyenv/asdf - remove shims when we detect respective installs via corresponding environment variables - make parsing more efficient with defensive regression testing to make sure we parse all options Signed-off-by: Dan Ryan <dan@danryan.co>
- Reformat and remove unused code Signed-off-by: Dan Ryan <dan@danryan.co>
hrm i've been struggling with caching / clearing the cache... on here... |
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Check the CI, the result is very interesting. It looks like it is not problem with xdist. The tests are still failing in python34 and 35 |
Finally I figured out why the tests are failing. It is because Feel free to revert this commit if you don't like it. 😃 |
No we definitely want to avoid that. We just need to handle name correctly. I swapped them because I profiled with a flamegraph and subprocess calls are wildly slow. Swapping the ordering here cut the runtime in 1/9. It should just use subprocess if it thinks it has a python version but actually doesn’t t |
Oh, it is for the performance. I missed that. So we only need to handle the names better. I reverted the commit :D |
a68c265
to
c83b691
Compare
Signed-off-by: Dan Ryan <dan@danryan.co>
…finder into feature/add-typechecking
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
would activate the finders in question
2.7.15+
version parsing atm