Feature/add typechecking

.coveragerc

@@ -1,7 +1,7 @@
 [run]
 branch = True
-parallel = True
 source = src/pythonfinder/
+omit = src/pythonfinder/_vendor/*
 
 [report]
 # Regexes for lines to exclude from consideration

.travis.yml

@@ -9,7 +9,7 @@ matrix:
 install:
   - "pip install --upgrade pip pipenv pytest pytest-cov pytest-timeout --upgrade-strategy=eager"
   - "pipenv install --dev"
-  - "pipenv run pip install --upgrade -e .[tests]"
+  - "pipenv run pip install --upgrade -e .[tests] pytest pytest-timeout pytest-cov --upgrade-strategy=eager"
 script:
   - "pipenv run pytest -ra tests/"
 
@@ -26,14 +26,14 @@ jobs:
     - stage: packaging
       python: "3.6"
       install:
-        - "pip install --upgrade twine readme_renderer[md]"
+        - "pip install --upgrade setuptools twine readme_renderer[md]"
       script:
         - "python setup.py sdist"
         - "twine check dist/*"
     - stage: coverage
       python: "3.6"
       install:
-        - "pip install --upgrade pip pipenv pytest pytest-cov pytest-timeout --upgrade-strategy=eager"
+        - "pip install --upgrade pip pipenv pytest-cov pytest-timeout pytest"
         - "pipenv install --dev"
       script:
         - "pipenv run pytest --timeout 300 --cov=pythonfinder --cov-report=term-missing --cov-report=xml --cov-report=html tests"

Pipfile

@@ -10,16 +10,17 @@ twine = "*"
 pytest-xdist = "*"
 invoke = "*"
 crayons = "*"
-pythonfinder = {path = ".", editable = true}
+pythonfinder = {path = ".",editable = true}
 sphinx-rtd-theme = "*"
 rope = "*"
-black = {version = "*", markers = "python_version>='3.6'"}
+black = {version = "*",markers = "python_version>='3.6'"}
 parver = "*"
 towncrier = "*"
-mypy = {version = "*", markers = "python_version>='3.4'"}
+mypy = {version = "*",markers = "python_version>='3.4'"}
 mypy_extensions = "*"
-typed-ast = {version = "*", markers = "python_version>='3.3'"}
+typed-ast = {version = "*",markers = "python_version>='3.3'"}
 lxml = "*"
+sphinx-autodoc-types = "*"
 
 [scripts]
 black = "python -m black src/pythonfinder"

README.rst

@@ -2,13 +2,13 @@ PythonFinder: Cross Platform Search Tool for Finding Pythons
 =============================================================
 
 .. image:: https://img.shields.io/pypi/v/pythonfinder.svg
-    :target: https://pypi.org/project/pythonfinder/
+    :target: https://pypi.org/project/pythonfinder
 
 .. image:: https://img.shields.io/pypi/l/pythonfinder.svg
-    :target: https://pypi.org/project/pythonfinder/
+    :target: https://pypi.org/project/pythonfinder
 
 .. image:: https://img.shields.io/pypi/pyversions/pythonfinder.svg
-    :target: https://pypi.org/project/pythonfinder/
+    :target: https://pypi.org/project/pythonfinder
 
 .. image:: https://img.shields.io/badge/Say%20Thanks-!-1EAEDB.svg
     :target: https://saythanks.io/to/techalchemy
@@ -22,13 +22,13 @@ Installation
 
 Install from `PyPI`_:
 
-  ::
+.. code-block:: console
 
-    $ pipenv install --pre pythonfinder
+    $ pipenv install pythonfinder
 
 Install from `Github`_:
 
-  ::
+.. code-block:: console
 
     $ pipenv install -e git+https://github.com/sarugaku/pythonfinder.git#egg=pythonfinder
 
@@ -44,19 +44,29 @@ Usage
 
 Using PythonFinder is easy.  Simply import it and ask for a python:
 
-  ::
+.. code-block:: pycon
+
+    >>> from pythonfinder.pythonfinder import PythonFinder
+    >>> PythonFinder.from_line('python3')
+    '/home/techalchemy/.pyenv/versions/3.6.5/python3'
 
     >>> from pythonfinder import Finder
     >>> f = Finder()
     >>> f.find_python_version(3, minor=6)
     PathEntry(path=PosixPath('/home/hawk/.pyenv/versions/3.6.5/bin/python'), _children={}, is_root=False, only_python=False, py_version=PythonVersion(major=3, minor=6, patch=5, is_prerelease=False, is_postrelease=False, is_devrelease=False, version=<Version('3.6.5')>, architecture='64bit', comes_from=PathEntry(path=PosixPath('/home/hawk/.pyenv/versions/3.6.5/bin/python'), _children={}, is_root=True, only_python=False, py_version=None, pythons=None), executable=None), pythons=None)
-
     >>> f.find_python_version(2)
-    PathEntry(path=PosixPath('/home/hawk/.pyenv/shims/python2'), _children={}, is_root=False, only_python=False, py_version=PythonVersion(major=2, minor=7, patch=15, is_prerelease=False, is_postrelease=False, is_devrelease=False, version=<Version('2.7.15')>, architecture='64bit', comes_from=PathEntry(path=PosixPath('/home/hawk/.pyenv/shims/python2'), _children={}, is_root=True, only_python=False, py_version=None, pythons=None), executable=None), pythons=None)
+    PathEntry(path=PosixPath('/home/hawk/.pyenv/shims/python2'), ...py_version=PythonVersion(major=2, minor=7, patch=15, is_prerelease=False, is_postrelease=False, is_devrelease=False, version=<Version('2.7.15')>, architecture='64bit', comes_from=PathEntry(path=PosixPath('/home/hawk/.pyenv/shims/python2'), _children={}, is_root=True, only_python=False, py_version=None, pythons=None), executable=None), pythons=None)
+    >>> f.find_python_version("anaconda3-5.3.0")
+
+Find a named distribution, such as ``anaconda3-5.3.0``:
+
+.. code-block:: pycon
 
-PythonFinder can even find beta releases!
+    PathEntry(path=PosixPath('/home/hawk/.pyenv/versions/anaconda3-5.3.0/bin/python3.7m'), _children={'/home/hawk/.pyenv/versions/anaconda3-5.3.0/bin/python3.7m': ...}, only_python=False, name='anaconda3-5.3.0', _py_version=PythonVersion(major=3, minor=7, patch=0, is_prerelease=False, is_postrelease=False, is_devrelease=False,...))
 
-  ::
+PythonFinder can even find beta releases:
+
+.. code-block:: pycon
 
     >>> f.find_python_version(3, minor=7)
     PathEntry(path=PosixPath('/home/hawk/.pyenv/versions/3.7.0b1/bin/python'), _children={}, is_root=False, only_python=False, py_version=PythonVersion(major=3, minor=7, patch=0, is_prerelease=True, is_postrelease=False, is_devrelease=False, version=<Version('3.7.0b1')>, architecture='64bit', comes_from=PathEntry(path=PosixPath('/home/hawk/.pyenv/versions/3.7.0b1/bin/python'), _children={}, is_root=True, only_python=False, py_version=None, pythons=None), executable=None), pythons=None)
@@ -70,7 +80,7 @@ Windows Support
 
 PythonFinder natively supports windows via both the *PATH* environment variable and `PEP-514 <https://www.python.org/dev/peps/pep-0514/>`_ compliant finder which comes by default with python 3. Usage on windows becomes:
 
-  ::
+.. code-block:: pycon
 
     >>> from pythonfinder import Finder
     >>> f = Finder()
@@ -88,7 +98,7 @@ Finding Executables
 
 PythonFinder also provides **which** functionality across platforms, and it uses lazy loading and fast-returns to be performant at this task.
 
-  ::
+.. code-block:: pycon
 
     >>> f.which('cmd')
     PathEntry(path=WindowsPath('C:/windows/system32/cmd.exe'), _children={}, is_root=False, only_python=False, py_version=None, pythons=None)
@@ -106,13 +116,19 @@ PythonFinder also provides **which** functionality across platforms, and it uses
 Architecture support
 ////////////////////
 
-PythonFinder supports architecture specific lookups on all platforms (coming soon):
+PythonFinder supports architecture specific lookups on all platforms:
+
+.. code-block:: pycon
+
+    >>> f.find_python_version(3, minor=6, arch="64")
+    PathEntry(path=PosixPath('/usr/bin/python3'), _children={'/usr/bin/python3': ...}, only_python=False, name='python3', _py_version=PythonVersion(major=3, minor=6, patch=7, is_prerelease=False, is_postrelease=False, is_devrelease=False, is_debug=False, version=<Version('3.6.7')>, architecture='64bit', comes_from=..., executable='/usr/bin/python3', name='python3'), _pythons=defaultdict(None, {}), is_root=False)
 
 
 Integrations
 *************
 
 * `Pyenv <https://github.com/pyenv/pyenv>`_
+* `ASDF <https://github.com/asdf-vm/asdf>`_
 * `PEP-514 <https://www.python.org/dev/peps/pep-0514/>`_
 * `Virtualenv <https://github.com/pypa/virtualenv>`_
 * `Pipenv <https://pipenv.org>`_

docs/conf.py

@@ -56,7 +56,7 @@ def find_version(*file_paths):
 project = 'PythonFinder'
 copyright = '2018, Dan Ryan <dan@danryan.co>'
 author = 'Dan Ryan <dan@danryan.co>'
-
+autosummary_generate = True
 
 # -- General configuration ---------------------------------------------------
 
@@ -72,7 +72,9 @@ def find_version(*file_paths):
     'sphinx.ext.viewcode',
     'sphinx.ext.todo',
     'sphinx.ext.intersphinx',
-    'sphinx.ext.autosummary'
+    'sphinx.ext.autosummary',
+    'sphinx_autodoc_typehints',
+    'sphinx_click.ext'
 ]
 
 # Add any paths that contain templates here, relative to this directory.
@@ -110,8 +112,8 @@ def find_version(*file_paths):
 html_theme = "sphinx_rtd_theme"
 
 extlinks = {
-    'issue': ('https://github.com/techalchemy/pythonfinder/issues/%s', '#'),
-    'pull': ('https://github.com/techalchemy/pythonfinder/pull/%s', 'PR #'),
+    'issue': ('https://github.com/sarugaku/pythonfinder/issues/%s', '#'),
+    'pull': ('https://github.com/sarugaku/pythonfinder/pull/%s', 'PR #'),
 }
 html_theme_options = {
     'display_version': True,

docs/pythonfinder.models.mixins.rst

@@ -0,0 +1,7 @@
+pythonfinder.models.mixins module
+=================================
+
+.. automodule:: pythonfinder.models.mixins
+    :members:
+    :undoc-members:
+    :show-inheritance:

docs/pythonfinder.models.rst

@@ -11,8 +11,8 @@ Submodules
 
 .. toctree::
 
+   pythonfinder.models.mixins
    pythonfinder.models.path
-   pythonfinder.models.pyenv
    pythonfinder.models.python
    pythonfinder.models.windows
 

docs/pythonfinder.rst

@@ -20,7 +20,7 @@ Submodules
 
    pythonfinder.cli
    pythonfinder.environment
-   pythonfinder.models
+   pythonfinder.exceptions
    pythonfinder.pythonfinder
    pythonfinder.utils
 

docs/quickstart.rst

@@ -22,13 +22,13 @@ Installation
 
 Install from `PyPI`_:
 
-  ::
+.. code-block:: console
 
-    $ pipenv install --pre pythonfinder
+    $ pipenv install pythonfinder
 
 Install from `Github`_:
 
-  ::
+.. code-block:: console
 
     $ pipenv install -e git+https://github.com/sarugaku/pythonfinder.git#egg=pythonfinder
 
@@ -44,7 +44,7 @@ Usage
 
 Using PythonFinder is easy.  Simply import it and ask for a python:
 
-  ::
+.. code-block:: pycon
 
     >>> from pythonfinder.pythonfinder import PythonFinder
     >>> PythonFinder.from_line('python3')
@@ -54,13 +54,19 @@ Using PythonFinder is easy.  Simply import it and ask for a python:
     >>> f = Finder()
     >>> f.find_python_version(3, minor=6)
     PathEntry(path=PosixPath('/home/hawk/.pyenv/versions/3.6.5/bin/python'), _children={}, is_root=False, only_python=False, py_version=PythonVersion(major=3, minor=6, patch=5, is_prerelease=False, is_postrelease=False, is_devrelease=False, version=<Version('3.6.5')>, architecture='64bit', comes_from=PathEntry(path=PosixPath('/home/hawk/.pyenv/versions/3.6.5/bin/python'), _children={}, is_root=True, only_python=False, py_version=None, pythons=None), executable=None), pythons=None)
-
     >>> f.find_python_version(2)
-    PathEntry(path=PosixPath('/home/hawk/.pyenv/shims/python2'), _children={}, is_root=False, only_python=False, py_version=PythonVersion(major=2, minor=7, patch=15, is_prerelease=False, is_postrelease=False, is_devrelease=False, version=<Version('2.7.15')>, architecture='64bit', comes_from=PathEntry(path=PosixPath('/home/hawk/.pyenv/shims/python2'), _children={}, is_root=True, only_python=False, py_version=None, pythons=None), executable=None), pythons=None)
+    PathEntry(path=PosixPath('/home/hawk/.pyenv/shims/python2'), ...py_version=PythonVersion(major=2, minor=7, patch=15, is_prerelease=False, is_postrelease=False, is_devrelease=False, version=<Version('2.7.15')>, architecture='64bit', comes_from=PathEntry(path=PosixPath('/home/hawk/.pyenv/shims/python2'), _children={}, is_root=True, only_python=False, py_version=None, pythons=None), executable=None), pythons=None)
+    >>> f.find_python_version("anaconda3-5.3.0")
+
+Find a named distribution, such as ``anaconda3-5.3.0``:
+
+.. code-block:: pycon
+
+    PathEntry(path=PosixPath('/home/hawk/.pyenv/versions/anaconda3-5.3.0/bin/python3.7m'), _children={'/home/hawk/.pyenv/versions/anaconda3-5.3.0/bin/python3.7m': ...}, only_python=False, name='anaconda3-5.3.0', _py_version=PythonVersion(major=3, minor=7, patch=0, is_prerelease=False, is_postrelease=False, is_devrelease=False,...))
 
-PythonFinder can even find beta releases!
+PythonFinder can even find beta releases:
 
-  ::
+.. code-block:: pycon
 
     >>> f.find_python_version(3, minor=7)
     PathEntry(path=PosixPath('/home/hawk/.pyenv/versions/3.7.0b1/bin/python'), _children={}, is_root=False, only_python=False, py_version=PythonVersion(major=3, minor=7, patch=0, is_prerelease=True, is_postrelease=False, is_devrelease=False, version=<Version('3.7.0b1')>, architecture='64bit', comes_from=PathEntry(path=PosixPath('/home/hawk/.pyenv/versions/3.7.0b1/bin/python'), _children={}, is_root=True, only_python=False, py_version=None, pythons=None), executable=None), pythons=None)
@@ -74,7 +80,7 @@ Windows Support
 
 PythonFinder natively supports windows via both the *PATH* environment variable and `PEP-514 <https://www.python.org/dev/peps/pep-0514/>`_ compliant finder which comes by default with python 3. Usage on windows becomes:
 
-  ::
+.. code-block:: pycon
 
     >>> from pythonfinder import Finder
     >>> f = Finder()
@@ -92,7 +98,7 @@ Finding Executables
 
 PythonFinder also provides **which** functionality across platforms, and it uses lazy loading and fast-returns to be performant at this task.
 
-  ::
+.. code-block:: pycon
 
     >>> f.which('cmd')
     PathEntry(path=WindowsPath('C:/windows/system32/cmd.exe'), _children={}, is_root=False, only_python=False, py_version=None, pythons=None)
@@ -110,13 +116,24 @@ PythonFinder also provides **which** functionality across platforms, and it uses
 Architecture support
 ////////////////////
 
-PythonFinder supports architecture specific lookups on all platforms (coming soon):
+PythonFinder supports architecture specific lookups on all platforms:
+
+.. code-block:: pycon
+
+    >>> f.find_python_version(3, minor=6, arch="64")
+    PathEntry(path=PosixPath('/usr/bin/python3'), _children={'/usr/bin/python3': ...}, only_python=False, name='python3', _py_version=PythonVersion(major=3, minor=6, patch=7, is_prerelease=False, is_postrelease=False, is_devrelease=False, is_debug=False, version=<Version('3.6.7')>, architecture='64bit', comes_from=..., executable='/usr/bin/python3', name='python3'), _pythons=defaultdict(None, {}), is_root=False)
 
 
 Integrations
 *************
 
 * `Pyenv <https://github.com/pyenv/pyenv>`_
+* `ASDF <https://github.com/asdf-vm/asdf>`_
 * `PEP-514 <https://www.python.org/dev/peps/pep-0514/>`_
 * `Virtualenv <https://github.com/pypa/virtualenv>`_
 * `Pipenv <https://pipenv.org>`_
+
+
+.. click:: pythonfinder:cli
+   :prog: pyfinder
+   :show-nested:

docs/requirements.txt

@@ -1,3 +1,4 @@
 sphinx
 sphinx-click
 sphinx_rtd_theme
+sphinx-autodoc-types

news/52.bugfix.rst

@@ -0,0 +1 @@
+Added typehints and refactored mixins, updated shims to only attempt to remove themselves if they detect their respectve installations (fixes Hynek's issue).

news/52.feature.rst

@@ -0,0 +1 @@
+Added typehints and refactored mixins, updated shims to only attempt to remove themselves if they detect their respectve installations (fixes Hynek's issue).