Skip to content

Add exception logging on connection auto close #3048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025
Merged

Add exception logging on connection auto close #3048

merged 1 commit into from
Mar 31, 2025

Conversation

ahopkins
Copy link
Member

Closes #3005

@ahopkins ahopkins requested a review from a team as a code owner March 31, 2025 07:16
@ahopkins ahopkins merged commit 7497554 into main Mar 31, 2025
27 checks passed
@ahopkins ahopkins deleted the issue3005 branch March 31, 2025 09:05
ahopkins added a commit that referenced this pull request Mar 31, 2025
* cleanup py3.8 (#3023)

* added minor type hinting (#3024)

* added minor type hinting

* apply linter

* Gh checks (#3041)

* Cleanup some typing

* Add custom CLI commands

* Add unit tests

* Align checks and versions

* Add SIGKILL type

* squash

* Add REPL context (#3042)

* Add REPL context

* fix(type): add missing return type

* chore: rename method and add docstring

* fix: handle null docstring

* chore: add test case

* Add direct attr setting

---------

Co-authored-by: goodki-d <185676088+goodki-d@users.noreply.github.com>

* Update README.rst

* Try websockets 11.0+ import first, then fall back to <11.0 (#3030)

Co-authored-by: Adam Hopkins <adam@amhopkins.com>

* Handle the websockets response body change (#3046)

* Cleanup some typing

* Add custom CLI commands

* Add unit tests

* Fix body check in websockets handshake

* Add missing test to workflow (#3028)

* Cleanup some typing

* Add custom CLI commands

* Add unit tests

* Add missing test to workflow

* Add default to response.cookies (#3047)

* Cleanup some typing

* Add custom CLI commands

* Add unit tests

* Add default to response cookies

* Add exception logging on connection auto close (#3048)

* Subclass init allow for kwargs (#3049)

* Release 25.3 (#3050)

---------

Co-authored-by: 疯人院主任 <erhuabushuo@gmail.com>
Co-authored-by: Ryu Juheon <saidbysolo@gmail.com>
Co-authored-by: goodki-d <185676088+goodki-d@users.noreply.github.com>
Co-authored-by: Eric Spitler <1396382+eric-spitler@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

return in finally swallows exceptions
1 participant