added minor type hinting #3024
Merged
added minor type hinting #3024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahopkins
approved these changes
Jan 5, 2025
ahopkins
previously approved these changes
Jan 13, 2025
|
looks like you need to run the linter |
|
It's strange that Python 3.11 / tox -e py310-no-ext CI doesn't trigger. |
SaidBySolo
force-pushed
the
SaidBySolo-patch-1
branch
from
8693277 to
6799037
Compare
ahopkins
approved these changes
Jan 15, 2025
ahopkins
added a commit
that referenced
this pull request
Mar 31, 2025
* cleanup py3.8 (#3023) * added minor type hinting (#3024) * added minor type hinting * apply linter * Gh checks (#3041) * Cleanup some typing * Add custom CLI commands * Add unit tests * Align checks and versions * Add SIGKILL type * squash * Add REPL context (#3042) * Add REPL context * fix(type): add missing return type * chore: rename method and add docstring * fix: handle null docstring * chore: add test case * Add direct attr setting --------- Co-authored-by: goodki-d <185676088+goodki-d@users.noreply.github.com> * Update README.rst * Try websockets 11.0+ import first, then fall back to <11.0 (#3030) Co-authored-by: Adam Hopkins <adam@amhopkins.com> * Handle the websockets response body change (#3046) * Cleanup some typing * Add custom CLI commands * Add unit tests * Fix body check in websockets handshake * Add missing test to workflow (#3028) * Cleanup some typing * Add custom CLI commands * Add unit tests * Add missing test to workflow * Add default to response.cookies (#3047) * Cleanup some typing * Add custom CLI commands * Add unit tests * Add default to response cookies * Add exception logging on connection auto close (#3048) * Subclass init allow for kwargs (#3049) * Release 25.3 (#3050) --------- Co-authored-by: 疯人院主任 <erhuabushuo@gmail.com> Co-authored-by: Ryu Juheon <saidbysolo@gmail.com> Co-authored-by: goodki-d <185676088+goodki-d@users.noreply.github.com> Co-authored-by: Eric Spitler <1396382+eric-spitler@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.