Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix structure display for section items with Canvas references #284

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Fix structure display for section items with Canvas references #284

merged 2 commits into from
Nov 10, 2023

Conversation

Dananji
Copy link
Collaborator

@Dananji Dananji commented Nov 9, 2023

When playhead is at a timestamp not included in a timespan in the structure:
image

When playhead is at a timestamp included in a timespan in the structure:
image

@Dananji Dananji mentioned this pull request Nov 9, 2023
Closed
masaball
masaball approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@masaball masaball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Dananji Dananji merged commit 385cfb3 into main Nov 10, 2023
2 checks passed
@Dananji Dananji deleted the section-item-fix branch November 10, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masaball masaball masaball approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dananji @masaball