Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] All Timespans are Highlighted for a Canvas/Section #281

Closed
Dananji opened this issue Nov 8, 2023 · 3 comments
Closed

[BUG] All Timespans are Highlighted for a Canvas/Section #281

Dananji opened this issue Nov 8, 2023 · 3 comments
Assignees
@joncameron

Comments

@Dananji
Copy link
Collaborator

Dananji commented Nov 8, 2023

Description

In Avalon manifests we have Canvas information for each Range at a section level, and this creates a navigable structure item for Ramp's structured navigation component.
With this change, Ramp's structured navigation looks like in the image for timestamps where there are no child timespans in the structure;
Private Zenhub Image

This probably should not highlight all the timespans? And highlight the entire time-rail (progress bar)?

Done Looks Like
@Dananji Dananji added bug 🐛 Something isn't working player Changes/fixes in player component structured_nav Improvements/fixes in structured nav labels Nov 8, 2023
@Dananji
Copy link
Collaborator Author

Dananji commented Nov 9, 2023

Fixed by #284

@joncameron
Copy link
Contributor

joncameron commented Nov 15, 2023 •
edited
Loading

Needs to be retested to confirm it's fixed by #284 and working in Avalon. @joncameron

@joncameron joncameron self-assigned this Nov 16, 2023
@joncameron joncameron removed bug 🐛 Something isn't working structured_nav Improvements/fixes in structured nav player Changes/fixes in player component labels Nov 28, 2023
@joncameron
Copy link
Contributor

Tested and confirmed fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joncameron joncameron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Dananji @joncameron