Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the CC file manager (integrate it into the UI) #2321

Closed
hackartisan opened this issue Jul 5, 2016 · 19 comments
Closed

Support the CC file manager (integrate it into the UI) #2321

hackartisan opened this issue Jul 5, 2016 · 19 comments

Comments

@hackartisan
Copy link
Contributor

hackartisan commented Jul 5, 2016

Once we have nested works, we want to be able to order objects within works.

Blocked by #2199 and #2243.

@hackartisan hackartisan added this to the 7.1.0 milestone Jul 5, 2016
@hackartisan hackartisan changed the title support the CC file manager (integrate it into the UI) Support the CC file manager (integrate it into the UI) Jul 5, 2016
@mjgiarlo
Copy link
Member

mjgiarlo commented Jul 5, 2016

Related to (and blocked by) #2243.

@mjgiarlo
Copy link
Member

mjgiarlo commented Jul 5, 2016

This may be an epic.

@hackartisan
Copy link
Contributor Author

We also need to be able to order files (FileSet objects) which I gathered is part of the file manager, as well. My understanding is that Works and FileSets can be ordered (and intermingled) on a given parent.

@mjgiarlo
Copy link
Member

mjgiarlo commented Jul 5, 2016

@HackMasterA This would be good to verify in the latest release of CC.

@mjgiarlo mjgiarlo added the ready label Aug 1, 2016
@mjgiarlo mjgiarlo modified the milestones: 7.1.0, 7.2.0 Aug 1, 2016
@mjgiarlo
Copy link
Member

mjgiarlo commented Aug 8, 2016

@HackMasterA A good first bit of work for this ticket would be to spin up CC and see what all tools it provides around ordering (of collections, works, and filesets). A follow-up would be to see how we might enable these same features in Sufia.

@hackartisan hackartisan self-assigned this Aug 9, 2016
@hackartisan
Copy link
Contributor Author

Messed around with curation concerns.

Works: There's a link on a work view page 'File Manager'. The file manager (see screenshot) allows you to drag/drop reorder files and works. Each File(Set)/Work object has a little box with thumbnail, editable title, 'edit' link going to e.g. /concern/parent/p5547r588/file_sets/vq27zn652. Thumbnail links to e.g. /concern/file_sets/vq27zn652. Both links take you to identical pages except the route; I don't understand this.

There's no ordering on Collections or FileSets. FileSets also don't appear to allow manual additions at this time.

screen shot 2016-08-09 at 11 07 26 am

@hackartisan
Copy link
Contributor Author

file_manager exists in sufia but looks a little wonky.

screen shot 2016-08-09 at 11 49 58 am

@hackartisan
Copy link
Contributor Author

There's no drag/drop functionality in the sufia page. probably missing javascript. I guess the question is do we want this functionality separate or do we want it as part of our works edit form? In UI discussions i recall an assumption of the latter. but since ordering can intermingle files and nested works I'm not sure that's possible; they're under different tabs. Maybe that decision should be revisited, even.

@mjgiarlo
Copy link
Member

mjgiarlo commented Aug 9, 2016

@HackMasterA Great, thanks for the investigation so far!

Re:

I guess the question is do we want this functionality separate or do we want it as part of our works edit form? In UI discussions i recall an assumption of the latter. but since ordering can intermingle files and nested works I'm not sure that's possible; they're under different tabs. Maybe that decision should be revisited, even.

what do you think about raising it on tomorrow's Hydra Tech call?

@hackartisan
Copy link
Contributor Author

@mjgiarlo sure I'll add it to the agenda for tomorrow. see also #2432

@mjgiarlo
Copy link
Member

mjgiarlo commented Aug 9, 2016

@HackMasterA yep, just dropped a comment there too. 😄

@hackartisan
Copy link
Contributor Author

Tech call revealed no strong feelings on the location of this functionality, but support for providing it.

@mjgiarlo
Copy link
Member

@HackMasterA If you have strong leanings, I'd encourage you to follow them, then! Barring that, we should look to better align Sufia and CC by having Sufia use/link to the file manager in the same place(s) if that sounds reasonable to you.

Thanks for running that by the tech call folks.

@hackartisan
Copy link
Contributor Author

Here are the different options for this, UI-wise.

  1. Integrate child works and filesets into a single list/tab on the edit page.
    1. Integrate drag/drop functionality directly into this list.
      1. pros: Most consistent UI/UX; the approach discussed in Sufia UI working group
      2. cons: Probably will take the longest. Sufia codebase drifts from cc.
    2. Put a button linking to the filemanager near this list.
      1. pros: At least the button leading to this functionality is near the list when it's being edited
      2. cons: You're linking to a form from within another form. Confusing for developers and users to sort out the implications of this.
  2. Link to fileset manager from work show page for logged-in users with edit permission.
    1. pros: More achievable
    2. cons: not consistent with our UI/UX strategy. users wanting to order at upload time may be confused.

I believe 1(i) is the correct approach, but I do not have the time to make it happen. Therefore, in service of getting something working at all, I'll go for 2.

@mjgiarlo
Copy link
Member

@HackMasterA sounds good.

to confirm, 1(i) is #2459?

@hackartisan
Copy link
Contributor Author

hackartisan commented Aug 11, 2016

@mjgiarlo no, I didn't ticket 1(i). #2459 is something we have to do on the show page side regardless. because once we have these things ordered there's no view that shows their order unless we do that.

@mjgiarlo
Copy link
Member

Ah, duh. OK!

@hackartisan
Copy link
Contributor Author

blocked by samvera-deprecated/curation_concerns#896

@mjgiarlo
Copy link
Member

@HackMasterA unblocked by samvera-deprecated/curation_concerns#898, yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants