Broken javascript, especially in file manager

[hackartisan]

Descriptive summary

File uploader and File manager are both broken.

Javascript errors:

Making fileuploader the first require in app/assets/javascripts/curation_concerns/curation_concerns.js resolves the error and fixes the file uploader, but does not fix file manager.

Putting the filemanager requires first creates the following errors:

The problem appears to have been introduced in samvera/hydra-editor@d38f1e7#diff-cf46d4dddad62fda63f883d306e44679 because when I pin to its parent the filemanager works and when I pin hydra-editor to that commit it is broken.

The file_manager es6 files are getting wrapped with what I believe @jcoyne says is some almond stuff, but they were already getting prepended with some other stuff I think from babel and it seems that the almond stuff is breaking them. https://gist.github.com/hackmastera/d6d26a85d55cbc938041cc1beac41f85 shows the result I'm getting in my browser.

Expected behavior

File manager should allow drag/drop of files and works

Actual behavior

No drag and therefore also no drop.

Steps to reproduce the behavior

1. Pull master, do a new bundle install and engine cart generation
2. Run the test app. create a work some some files
3. navigate to file manager and attempt to drag something.

Related work

possibly related to #884?

[mjgiarlo]

Pinging @tpendragon about this ticket too.

[tpendragon]

@jcoyne I don't know anything about almond - can we just remove it, or should we be converting everything to work with it?

[tpendragon]

@HackMasterA Thank you so much for the detailed track-down. https://github.com/projecthydra/curation_concerns/compare/file_manager_issues fixes the JS part of the issue, but it looks like there's some ruby problems too that I'll try to identify tomorrow.