-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Upgrade GitLab CE to 18.0.0 #3107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- This hack was introduced by sameersbn#3027 in order to fix sameersbn#3010.
Todos:
Hints:
|
@sachilles Yes of course.
|
Thank you very much! |
Error on startup of the microservice
|
may related to #2859 : In postgreSQL 15 or later, users do not have CREATE and USAGE privileges on the public schema by default. |
line 471 of workflow output shows: gitlab-1 | - Ensure grants for user gitlab on schema public are correctly set Not sure, whether GRANT will try to fix it. |
I guess it's a problem with the privileges within the database; only the user Not sure why does the database |
I'm testing locally built image. It's a strange bit but I noticed that there is no table
|
Then, is it a problem that needs action on postgresql image? I'll try to fix and publish if so. |
Manuall fixing the grants to
helps. |
@kkimurak Could you be so kind and check the grants mentioned in https://github.com/kkimurak/docker-postgresql?tab=readme-ov-file#granting-user-access-to-a-database ? |
I guess the |
Should the grant be added to postgresql create_database*( in https://github.com/sameersbn/docker-postgresql/blob/master/runtime/functions ? |
This is strange, since at the end of https://github.com/kkimurak/docker-postgresql/blob/5c9eda05fc162eb8370448697ad5a14b5f42ac37/runtime/functions#L344 all grants are should be given to the user |
This is the database grant. We need also a grant to schema public. |
GRANT ALL ON SCHEMA public TO gitlab; |
Made sure to work and pushed kkimurak/docker-postgresql@1697c40. Preparing to release images (maybe edit 2025-05-18T1-29 (JST: +0900) : forget to specify database on GRANT. fixed by kkimurak/docker-postgresql@c9124dd |
…set" This reverts commit cf154bd.
I ran into the gitaly issue as well and it turned out to be a filesystem error. The "git" user from the new image is now 1001:1001 , while it was 1000:1000 in previous images. So I had to chown the volumes. |
1000:1000 is now "ubuntu", which is not needed in our case. So we could remove it. What do you think? |
@th-2021 If we don't need the user 'ubuntu' then we should remove the account. |
9438412
to
c9ec90d
Compare
in assets/runtime/functionsL2263: max-old-space-size should be 8192 (to match install.sh) |
Note: GitLab came up without any errors. However pushing code to a repository isn't possible and results in |
In Addition I found that the GitLab runners don't pick up any jobs. Furthermore, running all checks shows that sidekiq causes some issues. |
@sachilles
It seems the user In running 17.11.2
Locally built 18.0.0
|
@kkimurak Thanks for pointing into the right direction. Manually correcting the entry in |
@kkimurak There seems to be some changes since in ubuntu 24.04 the option I guess that the option In ubuntu 22.04 the option |
Oh I see.. https://manpages.ubuntu.com/manpages/jammy/man8/adduser.8.html The chagne seems to be imported from debian: https://salsa.debian.org/debian/adduser/-/merge_requests/79 |
Finally, the last build of this PR seems to work. I have tested the following functions:
From my point of view, there is nothing to be said against the corresponding release or mixing of this PR. |
Great. If there is anything to be worried about, it would be around backups (because I have not tested yet). |
Taking a backup was tested by myself. But restoring from backup not. |
Additional report: I was worried that removing the runit-systemd package and not installing the alternative (runit-run was recommended when I tested) would cause problems. |
Shall we install the replacement for runit-systemd, or not? |
I think we should release this version and if some problems are reported (hopefully) we'll manage to fix them. |
Maybe not. Let's pray:)
|
GitLab 18.0 Release (for more details see https://about.gitlab.com/releases/2025/05/15/gitlab-18-0-released/)