Skip to content

Upgrade PostgreSQL to 16 and Upgrade base ubuntu to noble-20240429 #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kiina
Copy link

@Kiina Kiina commented May 23, 2024

Use noble as a base image and add PostgreSQL 16 support

@th-2021
Copy link

th-2021 commented May 22, 2025

This should be added:
GRANT ALL ON SCHEMA public TO ;

This was changed in postgresql 15 and without it, db initialization will fail.

@kkimurak
Copy link
Contributor

It looks like there are a few other approaches. Looking at #168 (comment) , it is said that to create individual schema for database seems to be effective too.

Also, changing the user who executes query in create_database (value of -U option for psql command) from ${PG_USER} to ${DB_USER} may be effective. In other words, the aim is to make ${DB_USER} the owner of the database (that was suggested in sameersbn/docker-gitlab#3107 (comment)) . (In practice, a conditional branch to check whether the DB_USER parameter is set would be necessary.)

What I'm trying to say is that I'm starting to feel less confident that including that code (GRANT ...) in the kkimurak/sameersbn-postgresql codebase (kkimurak#1, kkimurak#5) was the right decision. Maybe it's something that docker-gitlab could have handled. I haven't been able to verify anything yet though..

@th-2021
Copy link

th-2021 commented May 22, 2025

The gitlab doc writes (https://docs.gitlab.com/install/installation/#7-database):
sudo -u postgres psql -d template1 -c "CREATE DATABASE gitlabhq_production OWNER git;"
I think in "functions" OWNER is not set. Maybe this is why official doc doesn't require the grant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants