feat: adding Earliest and Latest #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #468 +/- ##
==========================================
- Coverage 94.02% 93.97% -0.05%
==========================================
Files 16 16
Lines 2460 2490 +30
==========================================
+ Hits 2313 2340 +27
- Misses 146 148 +2
- Partials 1 2 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ccoVeille
reviewed
Jun 27, 2024
|
|
||
| max = times[0] | ||
|
|
||
| for i := 1; i < len(times); i++ { |
There was a problem hiding this comment.
Is there any reason you use for I++ loop and not a range ?
Suggested change
| for i := 1; i < len(times); i++ { | |
| for _, item := range items { | |
| if item.After(max) { | |
| max = item | |
| } | |
| } |
There was a problem hiding this comment.
To skip the first.
Comparing a zero value with item is not that safe.
github-actions bot
pushed a commit
to kairos-io/provider-kairos
that referenced
this pull request
Jun 27, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/samber/lo](https://togithub.com/samber/lo) | `v1.39.0` -> `v1.41.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>samber/lo (github.com/samber/lo)</summary> ### [`v1.41.0`](https://togithub.com/samber/lo/releases/tag/v1.41.0) [Compare Source](https://togithub.com/samber/lo/compare/v1.40.0...v1.41.0) #### What's Changed - feat: adding Elipse by [@​samber](https://togithub.com/samber) in [samber/lo#470 - feat: adding CoalesceOrEmpty by [@​samber](https://togithub.com/samber) in [samber/lo#469 - feat: adding Earliest and Latest by [@​samber](https://togithub.com/samber) in [samber/lo#468 - feat: adding duration by [@​samber](https://togithub.com/samber) in [samber/lo#471 - feat: adding FilterReject by [@​samber](https://togithub.com/samber) in [samber/lo#472 - feat: adding RejectMap by [@​samber](https://togithub.com/samber) in [samber/lo#473 **Full Changelog**: samber/lo@v1.34.0...v1.41.0 ### [`v1.40.0`](https://togithub.com/samber/lo/releases/tag/v1.40.0) [Compare Source](https://togithub.com/samber/lo/compare/v1.39.0...v1.40.0) #### What's Changed ##### Improvements - Use map indexing to speed up PickByKeys and OmitByKeys by [@​ericleb010](https://togithub.com/ericleb010) in [samber/lo#447 - ToSlicePtr: reduce allocations and improving speed by [@​yanmhlv](https://togithub.com/yanmhlv) in [samber/lo#465 - Feat: Adding zipby + unzipby by [@​samber](https://togithub.com/samber) in [samber/lo#449 - feat: add string conversion functions by [@​eiixy](https://togithub.com/eiixy) in [samber/lo#466 - Adding Mean and MeanBy by [@​usman1100](https://togithub.com/usman1100) in [samber/lo#414 ##### Doc & style - Fix typos by [@​szepeviktor](https://togithub.com/szepeviktor) in [samber/lo#384 - fix: instantiate typo by [@​testwill](https://togithub.com/testwill) in [samber/lo#374 - Fix typo in README.md by [@​eltociear](https://togithub.com/eltociear) in [samber/lo#369 - docs: update description for FindOrElse by [@​slomek](https://togithub.com/slomek) in [samber/lo#370 - style: no extra any type parameter by [@​d-enk](https://togithub.com/d-enk) in [samber/lo#429 - Fix IsNil link for pkg.go.dev by [@​invzhi](https://togithub.com/invzhi) in [samber/lo#418 - Docs: should use type int64 for lo.FlatMap in example by [@​apriil15](https://togithub.com/apriil15) in [samber/lo#435 ##### CI - CI: tests on multi go versions by [@​jiro4989](https://togithub.com/jiro4989) in [samber/lo#445 #### New Contributors - [@​szepeviktor](https://togithub.com/szepeviktor) made their first contribution in [samber/lo#384 - [@​testwill](https://togithub.com/testwill) made their first contribution in [samber/lo#374 - [@​eltociear](https://togithub.com/eltociear) made their first contribution in [samber/lo#369 - [@​slomek](https://togithub.com/slomek) made their first contribution in [samber/lo#370 - [@​ericleb010](https://togithub.com/ericleb010) made their first contribution in [samber/lo#447 - [@​yanmhlv](https://togithub.com/yanmhlv) made their first contribution in [samber/lo#465 - [@​eiixy](https://togithub.com/eiixy) made their first contribution in [samber/lo#466 - [@​jiro4989](https://togithub.com/jiro4989) made their first contribution in [samber/lo#445 - [@​d-enk](https://togithub.com/d-enk) made their first contribution in [samber/lo#429 - [@​usman1100](https://togithub.com/usman1100) made their first contribution in [samber/lo#414 - [@​invzhi](https://togithub.com/invzhi) made their first contribution in [samber/lo#418 - [@​apriil15](https://togithub.com/apriil15) made their first contribution in [samber/lo#435 **Full Changelog**: samber/lo@v1.39.0...v1.40.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 11pm every weekday,before 7am every weekday,every weekend" in timezone Europe/Brussels, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/kairos-io/provider-kairos). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjAuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyMC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
codeboten
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Jul 2, 2024
](https://renovatebot.com){kind=link}
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/samber/lo](https://togithub.com/samber/lo) | `v1.39.0` -> `v1.44.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>samber/lo (github.com/samber/lo)</summary> ### [`v1.44.0`](https://togithub.com/samber/lo/releases/tag/v1.44.0) [Compare Source](https://togithub.com/samber/lo/compare/v1.43.0...v1.44.0) #### What's Changed - feat: Add slice Splice an element or multiple elements at index i. by [@​wenlingang](https://togithub.com/wenlingang) in [samber/lo#371 - feat: Make Filter() preserve type. by [@​FGasper](https://togithub.com/FGasper) in [samber/lo#365 - feat: Added DropByIndex helper for slice by [@​phith0n](https://togithub.com/phith0n) in [samber/lo#398 - feat: upgrade to math/rand/v2 by [@​samber](https://togithub.com/samber) in [samber/lo#483 - chore: remove `golang.org/x/exp` since it doesn't follow go 1 compatibility promise by [@​trim21](https://togithub.com/trim21) in [samber/lo#478 #### New Contributors - [@​wenlingang](https://togithub.com/wenlingang) made their first contribution in [samber/lo#371 - [@​jason-zhj](https://togithub.com/jason-zhj) made their first contribution in [samber/lo#376 - [@​FGasper](https://togithub.com/FGasper) made their first contribution in [samber/lo#365 - [@​phith0n](https://togithub.com/phith0n) made their first contribution in [samber/lo#398 **Full Changelog**: samber/lo@v1.43.0...v1.44.0 ### [`v1.43.0`](https://togithub.com/samber/lo/releases/tag/v1.43.0) [Compare Source](https://togithub.com/samber/lo/compare/v1.42.0...v1.43.0) #### What's Changed - feat: adding HasKey by [@​samber](https://togithub.com/samber) in [samber/lo#477 - feat: adding lo.WaitFor by [@​samber](https://togithub.com/samber) in [samber/lo#269 - improvement: Optimize the performance of union method, avoid repeated expansion by [@​cwb2819259](https://togithub.com/cwb2819259) in [samber/lo#397 #### New Contributors - [@​cwb2819259](https://togithub.com/cwb2819259) made their first contribution in [samber/lo#397 **Full Changelog**: samber/lo@v1.42.0...v1.43.0 ### [`v1.42.0`](https://togithub.com/samber/lo/releases/tag/v1.42.0) [Compare Source](https://togithub.com/samber/lo/compare/v1.41.0...v1.42.0) #### What's Changed - feat: add Nil by [@​gubtos](https://togithub.com/gubtos) in [samber/lo#383 - feat: Add First and FirstOrZeroValue functions by [@​Alireza-Kiani](https://togithub.com/Alireza-Kiani) in [samber/lo#451 - feat: adding LastOrEmpty and LastOr by [@​samber](https://togithub.com/samber) in [samber/lo#474 - feat: Feature/contains iterate by index by [@​lennon-guan](https://togithub.com/lennon-guan) in [samber/lo#428 - feat: speed up loops by reducing allocations by [@​samber](https://togithub.com/samber) in [samber/lo#475 - doc: inconsistent expression in README.md by [@​rolancia](https://togithub.com/rolancia) in [samber/lo#406 #### New Contributors - [@​gubtos](https://togithub.com/gubtos) made their first contribution in [samber/lo#383 - [@​Alireza-Kiani](https://togithub.com/Alireza-Kiani) made their first contribution in [samber/lo#451 - [@​rolancia](https://togithub.com/rolancia) made their first contribution in [samber/lo#406 - [@​lennon-guan](https://togithub.com/lennon-guan) made their first contribution in [samber/lo#428 **Full Changelog**: samber/lo@v1.41.0...v1.42.0 ### [`v1.41.0`](https://togithub.com/samber/lo/releases/tag/v1.41.0) [Compare Source](https://togithub.com/samber/lo/compare/v1.40.0...v1.41.0) #### What's Changed - feat: adding Elipse by [@​samber](https://togithub.com/samber) in [samber/lo#470 - feat: adding CoalesceOrEmpty by [@​samber](https://togithub.com/samber) in [samber/lo#469 - feat: adding Earliest and Latest by [@​samber](https://togithub.com/samber) in [samber/lo#468 - feat: adding duration by [@​samber](https://togithub.com/samber) in [samber/lo#471 - feat: adding FilterReject by [@​samber](https://togithub.com/samber) in [samber/lo#472 - feat: adding RejectMap by [@​samber](https://togithub.com/samber) in [samber/lo#473 **Full Changelog**: samber/lo@v1.34.0...v1.41.0 ### [`v1.40.0`](https://togithub.com/samber/lo/releases/tag/v1.40.0) [Compare Source](https://togithub.com/samber/lo/compare/v1.39.0...v1.40.0) #### What's Changed ##### Improvements - Use map indexing to speed up PickByKeys and OmitByKeys by [@​ericleb010](https://togithub.com/ericleb010) in [samber/lo#447 - ToSlicePtr: reduce allocations and improving speed by [@​yanmhlv](https://togithub.com/yanmhlv) in [samber/lo#465 - Feat: Adding zipby + unzipby by [@​samber](https://togithub.com/samber) in [samber/lo#449 - feat: add string conversion functions by [@​eiixy](https://togithub.com/eiixy) in [samber/lo#466 - Adding Mean and MeanBy by [@​usman1100](https://togithub.com/usman1100) in [samber/lo#414 ##### Doc & style - Fix typos by [@​szepeviktor](https://togithub.com/szepeviktor) in [samber/lo#384 - fix: instantiate typo by [@​testwill](https://togithub.com/testwill) in [samber/lo#374 - Fix typo in README.md by [@​eltociear](https://togithub.com/eltociear) in [samber/lo#369 - docs: update description for FindOrElse by [@​slomek](https://togithub.com/slomek) in [samber/lo#370 - style: no extra any type parameter by [@​d-enk](https://togithub.com/d-enk) in [samber/lo#429 - Fix IsNil link for pkg.go.dev by [@​invzhi](https://togithub.com/invzhi) in [samber/lo#418 - Docs: should use type int64 for lo.FlatMap in example by [@​apriil15](https://togithub.com/apriil15) in [samber/lo#435 ##### CI - CI: tests on multi go versions by [@​jiro4989](https://togithub.com/jiro4989) in [samber/lo#445 #### New Contributors - [@​szepeviktor](https://togithub.com/szepeviktor) made their first contribution in [samber/lo#384 - [@​testwill](https://togithub.com/testwill) made their first contribution in [samber/lo#374 - [@​eltociear](https://togithub.com/eltociear) made their first contribution in [samber/lo#369 - [@​slomek](https://togithub.com/slomek) made their first contribution in [samber/lo#370 - [@​ericleb010](https://togithub.com/ericleb010) made their first contribution in [samber/lo#447 - [@​yanmhlv](https://togithub.com/yanmhlv) made their first contribution in [samber/lo#465 - [@​eiixy](https://togithub.com/eiixy) made their first contribution in [samber/lo#466 - [@​jiro4989](https://togithub.com/jiro4989) made their first contribution in [samber/lo#445 - [@​d-enk](https://togithub.com/d-enk) made their first contribution in [samber/lo#429 - [@​usman1100](https://togithub.com/usman1100) made their first contribution in [samber/lo#414 - [@​invzhi](https://togithub.com/invzhi) made their first contribution in [samber/lo#418 - [@​apriil15](https://togithub.com/apriil15) made their first contribution in [samber/lo#435 **Full Changelog**: samber/lo@v1.39.0...v1.40.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> Co-authored-by: Yang Song <songy23@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.