Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add First and FirstOrZeroValue functions #451

Merged
merged 4 commits into from
Jun 27, 2024
Merged

Conversation

Alireza-Kiani
Copy link
Contributor

@Alireza-Kiani Alireza-Kiani commented May 12, 2024

adding two new functions to find.go for fetching the first element of the slice.

@Alireza-Kiani Alireza-Kiani marked this pull request as draft May 12, 2024 00:16
@Alireza-Kiani Alireza-Kiani marked this pull request as ready for review May 12, 2024 00:22
@Alireza-Kiani Alireza-Kiani changed the title feat: add First and FirstOrZeroValue functions Add First and FirstOrZeroValue functions May 16, 2024
@samber
Copy link
Owner

samber commented Jun 27, 2024

To follow the go conventions, I would return value, ok instead of value, err.

To follow the samber/lo convention, I would replace "zero" with "empty" in naming.

func First[T]([]T) T

func FirstOrEmpty[T]([]T) T

func FirstOr[T]([]T, T) T

WDYT ?

@ccoVeille
Copy link
Contributor

I agree. Also, why doesn't FirstOrZero depends on First ?

@Alireza-Kiani
Copy link
Contributor Author

Hey guys, thanks for your replies. @samber You are right, the initial changes did not follow conventions properly, Updated the implementation according to your saying.

@ccoVeille Good point, I made a change to the implementation and right now other functions rely on the base First function for finding the first element instead of duplicate code.

@samber samber merged commit a94098f into samber:master Jun 27, 2024
8 checks passed
github-actions bot pushed a commit to kairos-io/provider-kairos that referenced this pull request Jun 28, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [github.com/samber/lo](https://togithub.com/samber/lo) | `v1.41.0` ->
`v1.42.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fsamber%2flo/v1.42.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fsamber%2flo/v1.42.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fsamber%2flo/v1.41.0/v1.42.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fsamber%2flo/v1.41.0/v1.42.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>samber/lo (github.com/samber/lo)</summary>

### [`v1.42.0`](https://togithub.com/samber/lo/releases/tag/v1.42.0)

[Compare
Source](https://togithub.com/samber/lo/compare/v1.41.0...v1.42.0)

#### What's Changed

- feat: add Nil by [@&#8203;gubtos](https://togithub.com/gubtos) in
[samber/lo#383
- feat: Add First and FirstOrZeroValue functions by
[@&#8203;Alireza-Kiani](https://togithub.com/Alireza-Kiani) in
[samber/lo#451
- feat: adding LastOrEmpty and LastOr by
[@&#8203;samber](https://togithub.com/samber) in
[samber/lo#474
- feat: Feature/contains iterate by index by
[@&#8203;lennon-guan](https://togithub.com/lennon-guan) in
[samber/lo#428
- feat: speed up loops by reducing allocations by
[@&#8203;samber](https://togithub.com/samber) in
[samber/lo#475
- doc: inconsistent expression in README.md by
[@&#8203;rolancia](https://togithub.com/rolancia) in
[samber/lo#406

#### New Contributors

- [@&#8203;gubtos](https://togithub.com/gubtos) made their first
contribution in
[samber/lo#383
- [@&#8203;Alireza-Kiani](https://togithub.com/Alireza-Kiani) made their
first contribution in
[samber/lo#451
- [@&#8203;rolancia](https://togithub.com/rolancia) made their first
contribution in
[samber/lo#406
- [@&#8203;lennon-guan](https://togithub.com/lennon-guan) made their
first contribution in
[samber/lo#428

**Full Changelog**:
samber/lo@v1.41.0...v1.42.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 11pm every weekday,before 7am
every weekday,every weekend" in timezone Europe/Brussels, Automerge - At
any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/kairos-io/provider-kairos).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjAuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyMC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
codeboten pushed a commit to open-telemetry/opentelemetry-collector-contrib that referenced this pull request Jul 2, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [github.com/samber/lo](https://togithub.com/samber/lo) | `v1.39.0` ->
`v1.44.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fsamber%2flo/v1.44.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fsamber%2flo/v1.44.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fsamber%2flo/v1.39.0/v1.44.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fsamber%2flo/v1.39.0/v1.44.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>samber/lo (github.com/samber/lo)</summary>

### [`v1.44.0`](https://togithub.com/samber/lo/releases/tag/v1.44.0)

[Compare
Source](https://togithub.com/samber/lo/compare/v1.43.0...v1.44.0)

#### What's Changed

- feat: Add slice Splice an element or multiple elements at index i. by
[@&#8203;wenlingang](https://togithub.com/wenlingang) in
[samber/lo#371
- feat: Make Filter() preserve type. by
[@&#8203;FGasper](https://togithub.com/FGasper) in
[samber/lo#365
- feat: Added DropByIndex helper for slice by
[@&#8203;phith0n](https://togithub.com/phith0n) in
[samber/lo#398
- feat: upgrade to math/rand/v2 by
[@&#8203;samber](https://togithub.com/samber) in
[samber/lo#483
- chore: remove `golang.org/x/exp` since it doesn't follow go 1
compatibility promise by [@&#8203;trim21](https://togithub.com/trim21)
in
[samber/lo#478

#### New Contributors

- [@&#8203;wenlingang](https://togithub.com/wenlingang) made their first
contribution in
[samber/lo#371
- [@&#8203;jason-zhj](https://togithub.com/jason-zhj) made their first
contribution in
[samber/lo#376
- [@&#8203;FGasper](https://togithub.com/FGasper) made their first
contribution in
[samber/lo#365
- [@&#8203;phith0n](https://togithub.com/phith0n) made their first
contribution in
[samber/lo#398

**Full Changelog**:
samber/lo@v1.43.0...v1.44.0

### [`v1.43.0`](https://togithub.com/samber/lo/releases/tag/v1.43.0)

[Compare
Source](https://togithub.com/samber/lo/compare/v1.42.0...v1.43.0)

#### What's Changed

- feat: adding HasKey by [@&#8203;samber](https://togithub.com/samber)
in
[samber/lo#477
- feat: adding lo.WaitFor by
[@&#8203;samber](https://togithub.com/samber) in
[samber/lo#269
- improvement: Optimize the performance of union method, avoid repeated
expansion by [@&#8203;cwb2819259](https://togithub.com/cwb2819259) in
[samber/lo#397

#### New Contributors

- [@&#8203;cwb2819259](https://togithub.com/cwb2819259) made their first
contribution in
[samber/lo#397

**Full Changelog**:
samber/lo@v1.42.0...v1.43.0

### [`v1.42.0`](https://togithub.com/samber/lo/releases/tag/v1.42.0)

[Compare
Source](https://togithub.com/samber/lo/compare/v1.41.0...v1.42.0)

#### What's Changed

- feat: add Nil by [@&#8203;gubtos](https://togithub.com/gubtos) in
[samber/lo#383
- feat: Add First and FirstOrZeroValue functions by
[@&#8203;Alireza-Kiani](https://togithub.com/Alireza-Kiani) in
[samber/lo#451
- feat: adding LastOrEmpty and LastOr by
[@&#8203;samber](https://togithub.com/samber) in
[samber/lo#474
- feat: Feature/contains iterate by index by
[@&#8203;lennon-guan](https://togithub.com/lennon-guan) in
[samber/lo#428
- feat: speed up loops by reducing allocations by
[@&#8203;samber](https://togithub.com/samber) in
[samber/lo#475
- doc: inconsistent expression in README.md by
[@&#8203;rolancia](https://togithub.com/rolancia) in
[samber/lo#406

#### New Contributors

- [@&#8203;gubtos](https://togithub.com/gubtos) made their first
contribution in
[samber/lo#383
- [@&#8203;Alireza-Kiani](https://togithub.com/Alireza-Kiani) made their
first contribution in
[samber/lo#451
- [@&#8203;rolancia](https://togithub.com/rolancia) made their first
contribution in
[samber/lo#406
- [@&#8203;lennon-guan](https://togithub.com/lennon-guan) made their
first contribution in
[samber/lo#428

**Full Changelog**:
samber/lo@v1.41.0...v1.42.0

### [`v1.41.0`](https://togithub.com/samber/lo/releases/tag/v1.41.0)

[Compare
Source](https://togithub.com/samber/lo/compare/v1.40.0...v1.41.0)

#### What's Changed

- feat: adding Elipse by [@&#8203;samber](https://togithub.com/samber)
in
[samber/lo#470
- feat: adding CoalesceOrEmpty by
[@&#8203;samber](https://togithub.com/samber) in
[samber/lo#469
- feat: adding Earliest and Latest by
[@&#8203;samber](https://togithub.com/samber) in
[samber/lo#468
- feat: adding duration by [@&#8203;samber](https://togithub.com/samber)
in
[samber/lo#471
- feat: adding FilterReject by
[@&#8203;samber](https://togithub.com/samber) in
[samber/lo#472
- feat: adding RejectMap by
[@&#8203;samber](https://togithub.com/samber) in
[samber/lo#473

**Full Changelog**:
samber/lo@v1.34.0...v1.41.0

### [`v1.40.0`](https://togithub.com/samber/lo/releases/tag/v1.40.0)

[Compare
Source](https://togithub.com/samber/lo/compare/v1.39.0...v1.40.0)

#### What's Changed

##### Improvements

- Use map indexing to speed up PickByKeys and OmitByKeys by
[@&#8203;ericleb010](https://togithub.com/ericleb010) in
[samber/lo#447
- ToSlicePtr: reduce allocations and improving speed by
[@&#8203;yanmhlv](https://togithub.com/yanmhlv) in
[samber/lo#465
- Feat: Adding zipby + unzipby by
[@&#8203;samber](https://togithub.com/samber) in
[samber/lo#449
- feat: add string conversion functions by
[@&#8203;eiixy](https://togithub.com/eiixy) in
[samber/lo#466
- Adding Mean and MeanBy by
[@&#8203;usman1100](https://togithub.com/usman1100) in
[samber/lo#414

##### Doc & style

- Fix typos by [@&#8203;szepeviktor](https://togithub.com/szepeviktor)
in
[samber/lo#384
- fix: instantiate typo by
[@&#8203;testwill](https://togithub.com/testwill) in
[samber/lo#374
- Fix typo in README.md by
[@&#8203;eltociear](https://togithub.com/eltociear) in
[samber/lo#369
- docs: update description for FindOrElse by
[@&#8203;slomek](https://togithub.com/slomek) in
[samber/lo#370
- style: no extra any type parameter by
[@&#8203;d-enk](https://togithub.com/d-enk) in
[samber/lo#429
- Fix IsNil link for pkg.go.dev by
[@&#8203;invzhi](https://togithub.com/invzhi) in
[samber/lo#418
- Docs: should use type int64 for lo.FlatMap in example by
[@&#8203;apriil15](https://togithub.com/apriil15) in
[samber/lo#435

##### CI

- CI: tests on multi go versions by
[@&#8203;jiro4989](https://togithub.com/jiro4989) in
[samber/lo#445

#### New Contributors

- [@&#8203;szepeviktor](https://togithub.com/szepeviktor) made their
first contribution in
[samber/lo#384
- [@&#8203;testwill](https://togithub.com/testwill) made their first
contribution in
[samber/lo#374
- [@&#8203;eltociear](https://togithub.com/eltociear) made their first
contribution in
[samber/lo#369
- [@&#8203;slomek](https://togithub.com/slomek) made their first
contribution in
[samber/lo#370
- [@&#8203;ericleb010](https://togithub.com/ericleb010) made their first
contribution in
[samber/lo#447
- [@&#8203;yanmhlv](https://togithub.com/yanmhlv) made their first
contribution in
[samber/lo#465
- [@&#8203;eiixy](https://togithub.com/eiixy) made their first
contribution in
[samber/lo#466
- [@&#8203;jiro4989](https://togithub.com/jiro4989) made their first
contribution in
[samber/lo#445
- [@&#8203;d-enk](https://togithub.com/d-enk) made their first
contribution in
[samber/lo#429
- [@&#8203;usman1100](https://togithub.com/usman1100) made their first
contribution in
[samber/lo#414
- [@&#8203;invzhi](https://togithub.com/invzhi) made their first
contribution in
[samber/lo#418
- [@&#8203;apriil15](https://togithub.com/apriil15) made their first
contribution in
[samber/lo#435

**Full Changelog**:
samber/lo@v1.39.0...v1.40.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
Co-authored-by: Yang Song <songy23@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants