Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helper functions to sync auth modules located in salt://_auth to master/extmods/auth #51938

Merged
merged 9 commits into from
Mar 13, 2019

Conversation

cro
Copy link
Contributor

@cro cro commented Mar 1, 2019

What does this PR do?

This PR adds the helper functions necessary to sync auth modules from salt://_auth to /var/cache/salt/master/extmods/auth. Auth modules are already loaded by the loader, so manually putting them in the cache directory would cause Salt to "do the right thing" and load them when needed, there was just no way to get them there with Salt utilities.

What issues does this PR fix or reference?

No filed issue that I could see.

Previous Behavior

salt-run saltutil.sync_all would not copy auth modules. There was no salt-run saltutil.sync_auth at all.

New Behavior

salt-run saltutil.sync_all now copies auth modules to /var/cache/salt/master/extmods/auth where the loader will pick them up. There is a corresponding saltutil.sync_auth as well.

Commits signed with GPG?

Yes

@max-arnold
Copy link
Contributor

max-arnold commented Mar 2, 2019

It makes sense to update the docs (both the release notes and the module list https://docs.saltstack.com/en/develop/topics/development/modules/#module-types), add some tests and also add the corresponding state module (see #51900 which has a test for that) UPD: sorry, my mistake - a state is not required since it is a runner.

@dwoz
Copy link
Contributor

dwoz commented Mar 5, 2019

It makes sense to update the docs (both the release notes and the module list https://docs.saltstack.com/en/develop/topics/development/modules/#module-types), add some tests and also add the corresponding state module (see #51900 which has a test for that).

@cro ping.

@cro
Copy link
Contributor Author

cro commented Mar 13, 2019

ping @dwoz. This should be ready now.

@dwoz dwoz merged commit 7b52d3c into saltstack:develop Mar 13, 2019
Ch3LL added a commit to Ch3LL/salt that referenced this pull request Jul 24, 2019
Ch3LL added a commit to Ch3LL/salt that referenced this pull request Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants