Add missing saltutil.sync_* states #51900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-arnold
changed the title
max-arnold
force-pushed
the
saltutil-sync
branch
2 times, most recently
from
5bf9505
to
85e484f
Compare
max-arnold
commented
Feb 28, 2019
|
@dwoz Also, it looks like the docs build process doesn't clean removed files. One example is https://docs.saltstack.com/en/develop/ref/file_server/dynamic-modules.html, which was deleted in #50633 |
|
@dwoz I got the answer to my question (and the docs link seems to be fixed now), so the PR could be merged. I can rebase it if you want. |
|
@dwoz I believe this can be merged |
dwoz
approved these changes
May 13, 2019
mchugh19
pushed a commit
to mchugh19/salt
that referenced
this pull request
Oct 13, 2019
Add missing saltutil.sync_* states
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A follow-up patch for #50197 (issue #45264). Cc: @mchugh19
saltutil.sync_matchersandsaltutil.sync_serializersstatesstates.saltutildocsQuestion: does it make sense to also ensure function parity in the
saltutilrunner? https://docs.saltstack.com/en/develop/ref/runners/all/salt.runners.saltutil.html. The missing functions are:sync_beacons,sync_engines,sync_executors,sync_log_handlers,sync_matchers.Tests written?
Yes
Commits signed with GPG?
No