Skip to content

Optimize page access #940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2025
Merged

Optimize page access #940

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions src/table.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,13 +383,10 @@ impl Page {

#[inline]
fn assert_type<T: Slot>(&self) -> PageView<'_, T> {
assert_eq!(
self.slot_type_id,
TypeId::of::<T>(),
"page has slot type `{:?}` but `{:?}` was expected",
self.slot_type_name,
std::any::type_name::<T>(),
);
if self.slot_type_id != TypeId::of::<T>() {
type_assert_failed::<T>(self);
}

PageView(self, PhantomData)
}

Expand All @@ -403,6 +400,17 @@ impl Page {
}
}

/// This function is explicitly outlined to avoid debug machinery in the hot-path.
#[cold]
#[inline(never)]
fn type_assert_failed<T: 'static>(page: &Page) -> ! {
panic!(
"page has slot type `{:?}` but `{:?}` was expected",
page.slot_type_name,
std::any::type_name::<T>(),
)
}

impl Drop for Page {
fn drop(&mut self) {
let len = *self.allocated.get_mut();
Expand Down