Optimize page access #940
Merged
Optimize page access #940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #940 will not alter performanceComparing Summary
|
MichaReiser
approved these changes
Jul 19, 2025
MichaReiser
reviewed
Jul 19, 2025
Contributor
MichaReiser
left a comment
MichaReiser
left a comment
There was a problem hiding this comment.
Maybe add a comment explaining why it doesn't use assert
ibraheemdev
force-pushed
the
ibraheem/optimize-page-access
branch
from
3ec35df to
516d2fc
Compare
ibraheemdev
force-pushed
the
ibraheem/optimize-page-access
branch
from
dda8264 to
516d2fc
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The codegen for this function is pretty terrible currently because of all the debug machinery.