Sh/deploy zip size #1138
Merged
Sh/deploy zip size #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| before(async () => { | ||
| testkit = await TestSession.create({ | ||
| project: { gitClone: 'https://github.com/salesforcecli/sample-project-multiple-packages' }, |
There was a problem hiding this comment.
nice (archived repo so it can't break the NUT) 😁
|
QA notes: ✅ deploy with verbose, human/json output includes zip size/file count NOTE: tested by enabling telemetry in debug mode: then checking the payload written ✅ deploying a mdapi format folder shows both counters |
cristiand391
approved these changes
Aug 26, 2024
|
re-ran tests in my comment above (before HRO changes), all 🟢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Requires and consumes SDR PR 1403; the zipSize and zipFileCount fields on SDR's DeployResult and the deployZipData event. Displays this zip data in deploy command output and JSON response.
What issues does this PR fix or reference?
@W-16488140@
To test:
link SDR PR 1403 branch to this branch
Run deploy commands of various kinds with and without
--json. Note the zip size and zip file count output and fields.Turn on debug output and look for debug lines about zip size and file count
check out telemetry event with this data added
the JSON response with deploy commands will always have the zipSize and zipFileCount fields added, as long as the data is there in the event.