Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make deploy zip size and zip file count available #1403

Merged
merged 9 commits into from
Aug 26, 2024
Merged

feat: make deploy zip size and zip file count available #1403

merged 9 commits into from
Aug 26, 2024

Conversation

shetzel
Copy link
Contributor

@shetzel shetzel commented Aug 19, 2024

What does this PR do?

Adds zipSize and zipFileCount to DeployResults. Also, fire an event with zipSize and zipFileCount data for client consumption.

What issues does this PR fix or reference?

@W-16488114@
@W-16458613@

Added functionality

  • zipSize and zipFileCount are added to all DeployResults when known
  • deployZipData event is fired with zipSize and zipFileCount when known
  • zipSize is always known when a deploy is started
  • zipFileCount is known except when deploying a zip of metadata format files
  • zipSize and zipFileCount are sent as part of the metadata_api_deploy_result telemetry event

@shetzel shetzel requested a review from a team as a code owner August 19, 2024 21:38
@shetzel shetzel mentioned this pull request Aug 21, 2024
Merged
@cristiand391 cristiand391 merged commit 755c283 into main Aug 26, 2024
74 checks passed
@cristiand391 cristiand391 deleted the sh/deploy-zip-size branch August 26, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristiand391 cristiand391 cristiand391 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shetzel @cristiand391 @svc-cli-bot