fix: use Fragment VNodes for if-elseif-else children #3042
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jye-sf
commented
Sep 13, 2022
| ): t.Expression { | ||
| const ifBlockKey = key || codeGen.generateKey('if-fr'); |
There was a problem hiding this comment.
We use the same key for each branch of the if-elseif-else chain so that the different fragment vnodes are recognized as belonging to the same space. Thanks Jose for the recommendation.
jodarove
reviewed
Sep 16, 2022
| api_text("First Alternative Header"), | ||
| ]), | ||
| ]) | ||
| : api_fragment("if-fr0", stc2), |
There was a problem hiding this comment.
this fragment should have childrens, or should be just null in the else part?
There was a problem hiding this comment.
Good catch, this should just be null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Builds on top of #3034 to resolve issue with diffing algo. if-elseif-else children are now properly marked as fragments so that the diffing algo can update the nodes properly.
Has dependencies on both #3034 and #3030 and should only be merged into a branch that contains both those changes.
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item