refactor: Fragment VNode #3034
Merged
refactor: Fragment VNode #3034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jodarove
requested review from
nolanlawson,
pmdartus and
ravijayaramappa
and removed request for
nolanlawson
jodarove
commented
Sep 8, 2022
packages/@lwc/engine-server/src/__tests__/fixtures/comments-foreach/expected.html
Outdated
Show resolved
Hide resolved
jodarove
commented
Sep 8, 2022
jodarove
force-pushed
the
jodarove/vfragment
branch
from
5f3c264
to
5f287ac
Compare
This reverts commit 9aa6199.
jodarove
force-pushed
the
jodarove/vfragment
branch
from
5f287ac
to
59bbcc8
Compare
jye-sf
approved these changes
Sep 16, 2022
jye-sf
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR is the beginning of splitting #2957.
It introduces the VFragment vnode type, and the required routines to mount, patch, and hydrate a vnode; as well of how to generate a fragment in the compiler
For a general explanation, please read the one in the original PR
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
But notice that the new
VFragmentVNode requires two new empty text nodes which serve anchor points in the DOM. Those empty text nodes are observable from userland viaNode.prototype.children, Element.prototype.firstChild, Element.prototype.lastChild, Node.prototype.previousSibling and Node.prototype.nextSibling. As a side effect, Jest's snapshot tests would fail because those empty text nodes would generate empty lines surrounding the fragment.GUS work item