-
-
Notifications
You must be signed in to change notification settings - Fork 962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SAK-47702 Add sakai namespace prefix to site archive XML files #10811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The URI provided here isn't a real path on www.sakailms.org but that doesn't matter because it just needs to be unique.
ern
approved these changes
Aug 24, 2022
smarquard
added a commit
to cilt-uct/sakai
that referenced
this pull request
Sep 6, 2022
…project#10811) The URI provided here isn't a real path on www.sakailms.org but that doesn't matter because it just needs to be unique.
ern
pushed a commit
that referenced
this pull request
Sep 19, 2022
The URI provided here isn't a real path on www.sakailms.org but that doesn't matter because it just needs to be unique. (cherry picked from commit 5e71970)
TurRil
pushed a commit
to cilt-uct/sakai
that referenced
this pull request
Jan 8, 2024
…project#10811) The URI provided here isn't a real path on www.sakailms.org but that doesn't matter because it just needs to be unique.
TurRil
added a commit
to cilt-uct/sakai
that referenced
this pull request
Jan 8, 2024
* D2LBR-6 NYU changes for enhancements for site archiving (#79) * D2LBR-6 Initial application of NYU diffs From https://github.com/NYUeServ/sakai11/compare/master...NYUeServ:lms-migration.diff Probably doesn't build yet. Removed Kaltura-related code. * Add support for creating a site archive to SakaiScript * D2LBR-6 Resolve various merge issues - now builds * D2LBR-6 Remove some NYU references and flag two others * Fix some logging * Remove duplicate dependency and improve logging * Remove another NYU ref * Require user to be admin to create a site archive * Fix typo * D2LBR-6 Check for a valid siteid for archiving * Fix table name case for SAM_ITEMTEXT_T * D2LBR-6 Drop INFO logging to DEBUG as this seems harmless c/f https://sakaiproject.atlassian.net/browse/SAK-6133?focusedCommentId=179644 * D2LBR-6 Skip resources with exceptions to avoid a subsequent NPE * D2LBR-6 Fix getter methods for extra credit Lombok @Getter for boolean isSomething(), Boolean getSomething() * D2LBR-6 Replace NYU URLs with vula.uct.ac.za (Lessons & Syllabus) But we need to see how these are actually handled in migrated sites. * SAK-47126 Fix for assignments site archive * D2LBR-93 Catch exceptions in Lessons item archiving * SAK-47702 Add sakai namespace prefix to site archive XML files (sakaiproject#10811) The URI provided here isn't a real path on www.sakailms.org but that doesn't matter because it just needs to be unique. * D2LBR-152 Change section titles to h2 markup * SAK-47702 Add namespace to additional site archive .xml files (sakaiproject#10849) And define a constant for the namespace string * D2LBR-268 Preserve the pre-rewrite syllabus (course outline) XML * VULA-4412 Don't archive question pools when T&Q is not in the site Question Pools are owned by a user not a site but we don't want to archive unrelated question pools if T&Q is not used in this site. * VULA-4414 Improve error handling of archive failures Also commit improvements to SiteArchiver previously in patches * D2LBR-268 Syllabus structure and attachments Not sure if this URL format will improve anything for the D2L import yet * VULA-4413 Throw exceptions upstream for question pool archiving errors * VULA-4424 Check and report orphaned attachments archiving question pools * VULA-4423 Archive question pools used in any assessment in the site * VULA-4423 Include question pools referenced at an item level * Commit patches for Forums archiving SAK-47901 SAK-47902 SAK-47921 MIG-96 * VULA-4429 Skip over invalid question pools * AMA-120 Export attachments correctly for published assessments * AMA-120 AMA-187 Correct published assessment attachment export * VULA-4435 Add line breaks to Lessons XML * AMA-367 Cross-site video resources in Lessons Archiving code for migration * AMA-625 Cleanup to align with upstream master * AMA-625 Align with master * AMA-625 Remove custom NYU Lessons re-writing code LessonsRejigger migrated to python previously. AMA-698 for migration of QuizTitleHappyMaker. SubPageWhacker (AMA-699) does not seem needed. * Remove unused maven repo * AMA-840 Archive cross-site references in html Lessons type 5 html content with src targets to other sites * AMA-121 Archive T&Q inline images * AMA-367 Include type 1 cross-site resources * VULA-4536: fixes after cherry-pick --------- Co-authored-by: Stephen Marquard <stephen.marquard@uct.ac.za>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The URI provided here isn't a real path on www.sakailms.org but that doesn't matter because it just needs to be unique.