forked from sakaiproject/sakai
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vula 4536 Apply UCT Changes #81
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* D2LBR-6 Initial application of NYU diffs From https://github.com/NYUeServ/sakai11/compare/master...NYUeServ:lms-migration.diff Probably doesn't build yet. Removed Kaltura-related code. * Add support for creating a site archive to SakaiScript * D2LBR-6 Resolve various merge issues - now builds * D2LBR-6 Remove some NYU references and flag two others * Fix some logging * Remove duplicate dependency and improve logging * Remove another NYU ref * Require user to be admin to create a site archive * Fix typo * D2LBR-6 Check for a valid siteid for archiving * Fix table name case for SAM_ITEMTEXT_T * D2LBR-6 Drop INFO logging to DEBUG as this seems harmless c/f https://sakaiproject.atlassian.net/browse/SAK-6133?focusedCommentId=179644 * D2LBR-6 Skip resources with exceptions to avoid a subsequent NPE * D2LBR-6 Fix getter methods for extra credit Lombok @Getter for boolean isSomething(), Boolean getSomething() * D2LBR-6 Replace NYU URLs with vula.uct.ac.za (Lessons & Syllabus) But we need to see how these are actually handled in migrated sites.
…project#10811) The URI provided here isn't a real path on www.sakailms.org but that doesn't matter because it just needs to be unique.
…roject#10849) And define a constant for the namespace string
Question Pools are owned by a user not a site but we don't want to archive unrelated question pools if T&Q is not used in this site.
Also commit improvements to SiteArchiver previously in patches
Not sure if this URL format will improve anything for the D2L import yet
SAK-47901 SAK-47902 SAK-47921 MIG-96
Archiving code for migration
LessonsRejigger migrated to python previously. AMA-698 for migration of QuizTitleHappyMaker. SubPageWhacker (AMA-699) does not seem needed.
Lessons type 5 html content with src targets to other sites
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are accessibility issues in these changes.
List<String> result = new ArrayList<>(); | ||
org.jsoup.nodes.Document htmlDoc = Jsoup.parse(qText); | ||
|
||
// Typically audio or video <source> or <img> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image is missing a text alternative. This is a problem for people using screen readers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referring to commits in 21.x and cherry-picked and merged.