Fix various errors found during LTO build #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thaodan
force-pushed
the
lto_and_various_build_fixes
branch
2 times, most recently
from
bb29f77 to
58f5e84
Compare
meson incorrectly tries to use ccache if it's accelerated even when it does not exist Signed-off-by: Ville Nummela <ville.nummela@jolla.com>
[sb2] Conditionally accelerate ccache. JB#61370
Signed-off-by: Björn Bidar <bjorn.bidar@jolla.com>
`egrep` and `fgrep` are deprecated, use `grep -E` or `grep -F` respectively. Replace `$(...)` notation instead of legacy backticks. Avoid useless `cat` where `read` can do the job better. Signed-off-by: Björn Bidar <bjorn.bidar@jolla.com>
[sb2] Replace deprecated egrep, fgrep and cleanup
[sb2] Add gate for statx. JB#49501
Our sed is to old for the POSIX option. Signed-off-by: Björn Bidar <bjorn.bidar@jolla.com>
…ption [sb2] Use GNU option for extended sed. JB#59434
Paths for ldconfig is relative to the root passed with -r. Signed-off-by: Björn Bidar <bjorn.bidar@jolla.com>
Signed-off-by: Martin Kampas <martin.kampas@jolla.com>
Append to LD_PRELOAD instead of prepend, so that sb2, as the virtualization layer, sits at the very bottom. At least the Coverity scan build tool does not operate correctly if libsb2.so takes its action first. Signed-off-by: Martin Kampas <martin.kampas@jolla.com>
This (still) exists as a symlink to /usr/bin/env, so the rule should be included as we do in other similar cases.
Thaodan
force-pushed
the
lto_and_various_build_fixes
branch
3 times, most recently
from
d2dba9b to
173bf67
Compare
[sb2] Fix ldconfig use at build time. JB#61808
[sb2] Fix compatibility with LD_PRELOAD-based tools. JB#61781
Accelerate sh/bash installed under /usr and more cleanups
Signed-off-by: Björn Bidar <bjorn.bidar@thaodan.de>
lua.h isn't always inside in /usr/include, take LUA_CFLAGS as taken from pkgconfig. Signed-off-by: Björn Bidar <bjorn.bidar@jolla.com>
Thaodan
force-pushed
the
lto_and_various_build_fixes
branch
2 times, most recently
from
5c882e1 to
59d6b80
Compare
preload/vperm_statfuncts.c:122:5: warning: no previous prototype for ‘i_virtualize_struct_stat_internal’ [-Wmissing-prototypes] 122 | int i_virtualize_struct_stat_internal( Fixes: 0ecaef5 ([sb2] Add gate for statx. JB#49501) Signed-off-by: Björn Bidar <bjorn.bidar@jolla.com>
Thaodan
force-pushed
the
lto_and_various_build_fixes
branch
from
10580b1 to
fdc1d23
Compare
Fix implicit declaration of statx gate helper function and includes
martyone
reviewed
Jan 13, 2025
Thaodan
force-pushed
the
lto_and_various_build_fixes
branch
from
fdc1d23 to
e68d9e0
Compare
Thaodan
force-pushed
the
lto_and_various_build_fixes
branch
from
e68d9e0 to
5ac1124
Compare
mlehtima
reviewed
Feb 5, 2025
Thaodan
force-pushed
the
lto_and_various_build_fixes
branch
4 times, most recently
from
0f1cea8 to
5f70906
Compare
Gate stat64 and fix some errno issues in gates
Thaodan
force-pushed
the
lto_and_various_build_fixes
branch
from
5f70906 to
41fbb5f
Compare
The help output in ld-linux.so was moved behind the --help flag.
ldexportlist was removed earlier for export.map. Replace with export.map where not done already. Remove obsolete references such as the target in preload/Makefile. Fixes: 20180ac Signed-off-by: Björn Bidar <bjorn.bidar@jolla.com>
Previously in some instance the assumption was $(SRCDIR) = $(OBJDIR). If $(OBJDIR) isn't equal to $(SRCDIR) these files were not found anymore. Signed-off-by: Björn Bidar <bjorn.bidar@jolla.com>
Thaodan
force-pushed
the
lto_and_various_build_fixes
branch
from
41fbb5f to
dd8240b
Compare
Thaodan
force-pushed
the
lto_and_various_build_fixes
branch
2 times, most recently
from
59da1f4 to
dd8240b
Compare
Resolves error when using a compiler with stricter settings such as when using LTO. Signed-off-by: Björn Bidar <bjorn.bidar@jolla.com>
…JB#61866 Both open and openat load their last argument 'mode' lazily, using va_arg() only if O_CREAT is found in oflag. This is wrong, mode is also necessary if O_TMPFILE is in oflag. Adapt __OPEN_NEEDS_MODE(oflag) present since glibc 2.22 to solve the issue. Read more down below: https://sourceware.org/git/?p=glibc.git;a=commit;h=65f6f938cd562a614a68e15d0581a34b177ec29d Signed-off-by: Björn Bidar <bjorn.bidar@jolla.com>
Once in autogen.sh and once in %make Signed-off-by: Björn Bidar <bjorn.bidar@jolla.com>
Previously preload/exported.h depended on preload/wrappers.c even thou both where generated from interface.master by gen-interface.pl. Refactor so that all generated preloader files depend on the interface and the gen-interface script. Signed-off-by: Björn Bidar <bjorn.bidar@jolla.com>
Signed-off-by: Björn Bidar <bjorn.bidar@jolla.com>
Thaodan
force-pushed
the
lto_and_various_build_fixes
branch
from
dd8240b to
03b66ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix out of tree builds when trying to find
scratchbox2_version.hContains #22.