[sb2] Replace deprecated egrep, fgrep and cleanup #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlehtima
requested changes
Jan 16, 2024
Signed-off-by: Björn Bidar <bjorn.bidar@jolla.com>
Thaodan
force-pushed
the
egrep_fpgrep
branch
2 times, most recently
from
648ec2d to
98146a8
Compare
mlehtima
requested changes
Jan 17, 2024
Thaodan
force-pushed
the
egrep_fpgrep
branch
3 times, most recently
from
7202b52 to
738b6be
Compare
mlehtima
requested changes
Jan 18, 2024
`egrep` and `fgrep` are deprecated, use `grep -E` or `grep -F` respectively. Replace `$(...)` notation instead of legacy backticks. Avoid useless `cat` where `read` can do the job better. Signed-off-by: Björn Bidar <bjorn.bidar@jolla.com>
mlehtima
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.