Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Adjust compiler settings and document optimizer usage #99

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

mmv08
Copy link
Member

@mmv08 mmv08 commented Oct 18, 2023

This PR:

  • Adjusts the compiler settings to use the latest solc compiler and document the settings

@mmv08 mmv08 requested review from nlordell, a team, rmeissner, Uxio0 and akshay-ap and removed request for a team October 18, 2023 14:49
@mmv08 mmv08 force-pushed the feature/document-optimizer-usage branch from d7ef239 to 9b3bcbd Compare October 18, 2023 14:50
@coveralls
Copy link

coveralls commented Oct 18, 2023

Pull Request Test Coverage Report for Build 6572766915

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.647%

Totals Coverage Status
Change from base Build 6572755292: 0.0%
Covered Lines: 102
Relevant Lines: 129

💛 - Coveralls

@nlordell
Copy link
Collaborator

nlordell commented Oct 19, 2023

Out of curiosity, is the opcode PUSH0, and do you know off the top of your head which chains don't support it still (if not, don't worry about answering)?

@mmv08
Copy link
Member Author

mmv08 commented Oct 19, 2023

Out of curiosity, is the opcode PUSH0, and do you know off the top of your head which chains don't support it still (if not, don't worry about answering)?

Yes, it's the one. In my case, it was polygon Mumbai and a local hardhat node :D

@mmv08 mmv08 force-pushed the feature/document-optimizer-usage branch from 9b3bcbd to 464f392 Compare October 19, 2023 09:41
@mmv08 mmv08 merged commit f5d734b into master Oct 19, 2023
4 checks passed
@mmv08 mmv08 deleted the feature/document-optimizer-usage branch October 19, 2023 09:51
@nlordell
Copy link
Collaborator

Just noticed, but the solc version in package.json is still 0.8.14. I think this would affect the "local verify" task.

@mmv08
Copy link
Member Author

mmv08 commented Oct 19, 2023

Just noticed, but the solc version in package.json is still 0.8.14. I think this would affect the "local verify" task.

Yes, and also the code size one. I don't know if relying on a separate solc dependency is optimal instead of using the one from Hardhat. But in the meantime, it would be great if you adjust it in your testing PR, or I can create a separate PR to address this.

nlordell added a commit that referenced this pull request Oct 23, 2023
Supersedes #100 

This PR implements the suggestion from
#100 (review)
(thanks @mmv08 for the suggestion!), and migrates the 4337 package to
use the latest `hardhat` with `@nomicfoundation/hardhat-toolbox` in
order to simplify dependency management (it also removes a lot of extra
dependencies that were pulled in by `ethereal-waffle` 🎉).

Note that, in order to use the latest version of `hardhat` and
`hardhat-toolbox`, the codebase needed to migrate to Ethers.js v6 which
caused some fairly small changes to the existing TypeScript codebase.

Some additional dependency version changes that may seem unrelated but
worth clarifying:

* `solc`: A follow up to
#99, where the direct
`solc` version didn't change to reflect the hardhat compiler settings
* `@types/node`: Updated to the LTS version of node, which we intend to
use.

Additionally, for testing I was able to execute the `runOp` script
([tx](https://goerli.etherscan.io/tx/0xc1edbf6eb28c37f9df8df1bf44b79bf87fe037b1bf114278718276379bc75ace)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants