-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Adjust compiler settings and document optimizer usage #99
Conversation
d7ef239
to
9b3bcbd
Compare
Pull Request Test Coverage Report for Build 6572766915
💛 - Coveralls |
Out of curiosity, is the opcode |
Yes, it's the one. In my case, it was polygon Mumbai and a local hardhat node :D |
9b3bcbd
to
464f392
Compare
…ture/document-optimizer-usage
Just noticed, but the |
Yes, and also the code size one. I don't know if relying on a separate solc dependency is optimal instead of using the one from Hardhat. But in the meantime, it would be great if you adjust it in your testing PR, or I can create a separate PR to address this. |
Supersedes #100 This PR implements the suggestion from #100 (review) (thanks @mmv08 for the suggestion!), and migrates the 4337 package to use the latest `hardhat` with `@nomicfoundation/hardhat-toolbox` in order to simplify dependency management (it also removes a lot of extra dependencies that were pulled in by `ethereal-waffle` 🎉). Note that, in order to use the latest version of `hardhat` and `hardhat-toolbox`, the codebase needed to migrate to Ethers.js v6 which caused some fairly small changes to the existing TypeScript codebase. Some additional dependency version changes that may seem unrelated but worth clarifying: * `solc`: A follow up to #99, where the direct `solc` version didn't change to reflect the hardhat compiler settings * `@types/node`: Updated to the LTS version of node, which we intend to use. Additionally, for testing I was able to execute the `runOp` script ([tx](https://goerli.etherscan.io/tx/0xc1edbf6eb28c37f9df8df1bf44b79bf87fe037b1bf114278718276379bc75ace)).
This PR:
solc
compiler and document the settings