Update Hardhat and Related Depdendencies #100
Conversation
nlordell
force-pushed
the
update-hardhat-version
branch
from
4d6cb30
to
c06d2e8
Compare
There was a problem hiding this comment.
I suggest using the @nomicfoundation/hardhat-toolbox umbrella package to compose all the dependencies in one umbrella package. It's also the current hardhat's recommended way to bootstrap a project. More info can be found here:
https://hardhat.org/hardhat-runner/plugins/nomicfoundation-hardhat-toolbox
For an example code, you can check out the allowance module in this repo or safe-contracts repository
|
Also, when I was migrating the safe-contracts repo to the latest hardhat tooling, I had many problems with Waffle, so I had to remove it, and it was well worth it, I didn't lose any functionality. All the APIs exist in hardhat. Another reason for this is zksync compatibility - achieving this with as few dependencies as possible is easier. |
Supersedes #100 This PR implements the suggestion from #100 (review) (thanks @mmv08 for the suggestion!), and migrates the 4337 package to use the latest `hardhat` with `@nomicfoundation/hardhat-toolbox` in order to simplify dependency management (it also removes a lot of extra dependencies that were pulled in by `ethereal-waffle` 🎉). Note that, in order to use the latest version of `hardhat` and `hardhat-toolbox`, the codebase needed to migrate to Ethers.js v6 which caused some fairly small changes to the existing TypeScript codebase. Some additional dependency version changes that may seem unrelated but worth clarifying: * `solc`: A follow up to #99, where the direct `solc` version didn't change to reflect the hardhat compiler settings * `@types/node`: Updated to the LTS version of node, which we intend to use. Additionally, for testing I was able to execute the `runOp` script ([tx](https://goerli.etherscan.io/tx/0xc1edbf6eb28c37f9df8df1bf44b79bf87fe037b1bf114278718276379bc75ace)).
|
Superseded by #103 |
Part of #87
This PR updates
hardhatand related dependencies to the latest version. The choice to also update thehardhat-*packages was mostly to be sure that there aren't any unexpected incompatibilities with the actualhardhatversion being used (those changes can be reverted if necessary).Some notable changes that may seem unrelated but worth clarifying:
solidity-coverage: bump is required to fix integration with newerhardhatversions.solc: A follow up to Feature: Adjust compiler settings and document optimizer usage #99, where the directsolcversion didn't change to reflect thehardhatcompiler settings@types/node: Updated to the LTS version of node, which we intend to use.Another interesting change is the
@nomiclabs/hardhat-waffledependency was changed to an exact version. More recent versions of this package pull inethereum-wafflev4, which transitively pulls inganachev7, whose TypeScript definitions are causing compilation errors (I tried updating the compiler with hopes that it might fix the build errors but it did not).