Add gas estimation endpoint #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESLint Summary View Full Report
Report generated by eslint-plus-action |
katspaugh
reviewed
Sep 14, 2021
katspaugh
reviewed
Sep 14, 2021
| operation: 0, | ||
| }) | ||
| console.log(result) | ||
| expect(result.safeTxGas).toBe('43663') |
There was a problem hiding this comment.
While doing the exact same operation tt should be deterministic at least until the smart contract is updated
| describe('callEndpoint', () => { | ||
| it('should accept just a path', async () => { | ||
| await expect( | ||
| callEndpoint('https://safe-client.xdai.staging.gnosisdev.com/v1', '/balances/supported-fiat-codes'), |
There was a problem hiding this comment.
Wow, how did this work before? 👀
There was a problem hiding this comment.
While the not unified version is online this would work, but, as we already switched to the unified version better to update this just in case 😉
There was a problem hiding this comment.
Ah, because it's not TypeScript. It didn't detect that this endpoint doesn't exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #14
How this PR fixes it
Add new gas estimation endpoint and types