Skip to content

Conversation

@usame-algan
Copy link
Contributor

What it solves

Part of safe-global/safe-wallet-monorepo#1890

In #117, we updated the type for data in DecodedDataResponse to be nullable but the corresponding type DataDecoded still had data to be optional which causes a type mismatch.

How it solves it

  • Update data in DataDecoded to be string | null

@usame-algan usame-algan requested a review from katspaugh April 24, 2023 10:00
@github-actions
Copy link

github-actions bot commented Apr 24, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please bump the version again, I'll publish it

@usame-algan usame-algan merged commit 82e4198 into main Apr 24, 2023
@usame-algan usame-algan deleted the fix-update-data branch April 24, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants