fix: Change type of data to be optional

[usame-algan]

What it solves

Part of #1890

valueDecoded.data can be null and should be reflected in the type.

Examples

Transaction where data is null:

Tx Service: https://safe-transaction-goerli.safe.global/api/v1/multisig-transactions/0x4383f5cbddee358aa1e44023874ba63b751df6ba445c494d5799ddc48eeb42ae/

CGW: https://safe-client.safe.global/v1/chains/5/transactions/multisig_0x7a9af6Ef9197041A5841e84cB27873bEBd3486E2_0x4383f5cbddee358aa1e44023874ba63b751df6ba445c494d5799ddc48eeb42ae

[github-actions]

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

• Result: ✅ success
• Annotations: 0 total

---

^{Report generated by eslint-plus-action}

[katspaugh]

Wait, so does it come as an actual null or undefined, or no field at all?

[katspaugh]

It should be explicitly string | null.
The types that are marked as optional, if they are not defined, they don't appear in the JSON at all, so it's different in those cases.

[usame-algan]

dataDecoded is also marked as optional but is actually returned as null in the CGW and TxService response. Is it possible to see which fields will appear in the JSON and which won't?

[katspaugh]

There are mistakes in the types apparently. I hope the new Nest.js CGW will have exportable types.

[usame-algan]

I changed it to be null instead.

[katspaugh]

👍