Skip to content

Add type for safe app features #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2023
Merged

Add type for safe app features #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da2c4af
add type for safe app features
mmv08 Jan 19, 2023
85a297f
version pamp 3.6.0
mmv08 Jan 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@safe-global/safe-gateway-typescript-sdk",
"version": "3.5.6",
"version": "3.6.0",
"main": "dist/index.js",
"types": "dist/index.d.ts",
"files": [
Expand Down
5 changes: 5 additions & 0 deletions src/types/safe-apps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ export type SafeAppProvider = {
name: string
}

export enum SafeAppFeatures {
BATCHED_TRANSACTIONS = 'BATCHED_TRANSACTIONS',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How often are you planning to edit these features?

We're moving web-core feature toggles from this SDK to web-core itself because we often edit them and it's not practical to release a package every time. YMMV.

Copy link
Contributor Author

@mmv08 mmv08 Jan 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only safe-specific feature apps have at the moment and we don't have any more on the horizon now. Having it in the web core makes sense but sdk should be fine for us as of now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a heads-up. We are planning to move the Features enum into web-core because it is annoying to always publish a new version of the safe-gateway-typescript-sdk only when a new feature is added.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only safe-specific feature apps have at the moment and we don't have any more on the horizon now. Having it in the web core makes sense but sdk should be fine for us as of now

}

export type SafeAppData = {
id: number
url: string
Expand All @@ -29,6 +33,7 @@ export type SafeAppData = {
provider?: SafeAppProvider
accessControl: SafeAppsAccessControlPolicies
tags: string[]
features: SafeAppFeatures[]
Copy link
Contributor

@DaniSomoza DaniSomoza Jan 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add in this PR the socialProfiles & developer_website types implemented here ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They're not implemented on the gateway yet

}

export type SafeAppsResponse = SafeAppData[]