Add type for safe app features #113
Conversation
ESLint Summary View Full Report
Report generated by eslint-plus-action |
| provider?: SafeAppProvider | ||
| accessControl: SafeAppsAccessControlPolicies | ||
| tags: string[] | ||
| features: SafeAppFeatures[] |
There was a problem hiding this comment.
Can we also add in this PR the socialProfiles & developer_website types implemented here ?
There was a problem hiding this comment.
They're not implemented on the gateway yet
| } | ||
|
|
||
| export enum SafeAppFeatures { | ||
| BATCHED_TRANSACTIONS = 'BATCHED_TRANSACTIONS', |
There was a problem hiding this comment.
How often are you planning to edit these features?
We're moving web-core feature toggles from this SDK to web-core itself because we often edit them and it's not practical to release a package every time. YMMV.
There was a problem hiding this comment.
This is the only safe-specific feature apps have at the moment and we don't have any more on the horizon now. Having it in the web core makes sense but sdk should be fine for us as of now
| } | ||
|
|
||
| export enum SafeAppFeatures { | ||
| BATCHED_TRANSACTIONS = 'BATCHED_TRANSACTIONS', |
There was a problem hiding this comment.
Just a heads-up. We are planning to move the Features enum into web-core because it is annoying to always publish a new version of the safe-gateway-typescript-sdk only when a new feature is added.
There was a problem hiding this comment.
This is the only safe-specific feature apps have at the moment and we don't have any more on the horizon now. Having it in the web core makes sense but sdk should be fine for us as of now
Implements updated types after safe-global/safe-config-service#755