[dev] [No Bug/PBI] Fix improper console warning in <ActionBarSearch>
#463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a minor regression with the newer functionality in `<ActionBarSearch>` where a `<Select>` con be combined with the search input, in order to help give context to a search term (to aid certain back-end calls that require this to correctly process searches where we're not just using a fell-text search powered by ElasticSearch), introduced in #452. Some validation logic resulted in a console warning about not using this new feature correctly, even if _consumer was not using it at all!_ This change corrects that issue.
groberts314
added
bug
priority: low
groberts314
requested review from
absqueued,
War777,
KacosPro and
fantaJinMode
War777
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor regression with the newer functionality in
<ActionBarSearch>where a<Select>can be combined with the search input, in order to help give context to a search term (to aid certain back-end calls that require this to correctly process searches where we're not just using a full-text search powered by ElasticSearch), introduced in #452. Some validation logic resulted in a console warning about not using this new feature correctly, even if consumer was not using it at all! This change corrects that issue.