Merge pull request #463 from saddlebackdev/feature/bug_fix_in_action_…

…bar_search [dev] [No Bug/PBI] Fix improper console warning in `<ActionBarSearch>`
saddlebackdev · Sep 26, 2023 · 8e60f42 · 8e60f42
2 parents 9e8f02d + ffac32c
commit 8e60f42
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/src/surfaces/actionBar/actionBarSearch.jsx b/src/surfaces/actionBar/actionBarSearch.jsx
@@ -133,12 +133,14 @@ class ActionBarSearch extends React.PureComponent {
             value,
         } = this.props;
 
-        const hasCorrectDataForSearchWithSelect = !isNil(searchWithSelect) &&
-        isArray(searchWithSelect.options) &&
-        isFunction(searchWithSelect.onChange) &&
-        ('value' in searchWithSelect);
+        const isUsingSearchWithSelect = !isNil(searchWithSelect);
 
-        if (!hasCorrectDataForSearchWithSelect) {
+        const hasCorrectDataForSearchWithSelect = isUsingSearchWithSelect &&
+            isArray(searchWithSelect.options) &&
+            isFunction(searchWithSelect.onChange) &&
+            ('value' in searchWithSelect);
+
+        if (isUsingSearchWithSelect && !hasCorrectDataForSearchWithSelect) {
             console.warn( // eslint-disable-line no-console
                 'Please provide correct props to integrate Select with action bar search. See documentation of react-cm-ui for more details.',
             );